migrate IP address operations from GraphQL to flaps Machines API #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace GraphQL-based IP address operations with REST API implementations: - Add flaps/flaps_ips.go with new REST API client methods for IP operations - Add new flaps actions: ipAssignmentsList, ipAssignmentCreate, ipAssignmentDelete - Remove resource_ip_addresses.go with legacy GraphQL IP operations - Remove GraphQL IP-related types from types.go This migration improves performance and consistency by using the flaps Machines API instead of GraphQL for IP address management operations. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix golangci-lint-action config: change skip-pkg-cache to skip-cache - Remove trailing whitespace from flaps/flaps_ips.go - Add newline at end of flaps/flaps_ips.go - Fix goimports formatting in types.go - Fix staticcheck SA1006: use errors.New instead of fmt.Errorf 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
The previous migration commit (4bbe41c) migrated regular IP assignment operations from GraphQL to REST API but inadvertently removed GraphQL-based egress IP operations that are still needed: - Restore AllocateEgressIPAddress() for allocating machine egress IPs - Restore GetEgressIPAddresses() for retrieving machine egress IPs - Restore ReleaseEgressIPAddress() for releasing machine egress IPs - Add missing GraphQL types and Query struct fields These egress IP operations are separate from regular IP assignments and still require GraphQL API access. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
flaps/flaps_ips.gowith client methods for listing, assigning, and releasing IP addressesresource_ip_addresses.goand related typesChanges
flaps/flaps_ips.go- New REST API client for IP operations with methods:ListIPAssignments()- List all IP assignments for an appAssignIPAddress()- Assign a new IP address to an appReleaseIPAddress()- Release an IP address from an appflaps/actions.goandflaps/flapsaction_string.go- Added new action types for IP assignment operationsresource_ip_addresses.go- Legacy GraphQL-based IP operationstypes.goBenefits
Test plan
🤖 Generated with Claude Code