Skip to content

chore: notes on suppressed security hub findings can be added now #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: notes on suppressed security hub findings can be added now #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions blueprints/foundational/customizations/lib/security-hub-automation-rules-stack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { Stack, StackProps, aws_securityhub as securityhub } from 'aws-cdk-lib';
import { Construct } from 'constructs';
import { CfnAutomationRule } from 'aws-cdk-lib/aws-securityhub';
import AutomationRulesFindingFiltersProperty = CfnAutomationRule.AutomationRulesFindingFiltersProperty;
import { Groups } from '../../config';

/**
* Configures AWS Security Hub automation rules in the delegated admin account
Expand Down Expand Up @@ -54,12 +55,10 @@ export class SecurityHubAutomationRulesStack extends Stack {
workflow: {
status: 'SUPPRESSED',
},
// This is not working due to https://github.com/aws/aws-cdk/issues/26749
// The workaround described in the issue cannot be used because the LZA validation of the CloudFormation template fails
// note: {
// updatedBy: AdministratorTeamName,
// text: description,
// },
note: {
updatedBy: Groups.awsAdministrator,
text: description,
},
},
type: 'FINDING_FIELDS_UPDATE',
},
Expand Down
Loading