Fix bug: Textarea question type detection in survey parsing #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanpieper
changed the title
dylanpieper
force-pushed
the
cookies-nav
branch
from
346f134 to
24cf365
Compare
Problem: Textarea questions were being parsed as "unknown" type instead of "textarea", preventing proper restoration when navigating between pages. Root cause: HTML extraction was only getting "form-control" class instead of the full "shiny-input-textarea form-control" class string for textarea elements. Solution: - Enhanced HTML extraction to check both class attribute and tag name - Added fallback logic for textarea elements with incomplete class strings - Replaced exact string matching with pattern matching for question types This ensures textarea questions are properly detected and restored during navigation, fixing cookie-based session management for text input fields. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
dylanpieper
force-pushed
the
cookies-nav
branch
from
9a0bcef to
2ad9f24
Compare
Collaborator
|
Thanks again for catching all these issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Textarea questions were being parsed as "unknown" type instead of "textarea", preventing proper restoration when navigating between pages.
Root cause: HTML extraction was only getting "form-control" class instead of the full "shiny-input-textarea form-control" class string for textarea elements.
Solution:
This ensures textarea questions are properly detected and restored during navigation, fixing cookie-based session management for text input fields.