Skip to content

Commit 5348104

Browse files
authored
fix bind:this used before assign (#363)
1 parent 9fe3db5 commit 5348104

File tree

7 files changed

+13
-9
lines changed

7 files changed

+13
-9
lines changed

packages/svelte2tsx/src/htmlxtojsx.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,8 +204,12 @@ export function convertHtmlxToJsx(
204204

205205
if (thisType) {
206206
str.remove(attr.start, attr.expression.start);
207-
str.appendLeft(attr.expression.start, `{...__sveltets_ensureType(${thisType}, `);
208-
str.overwrite(attr.expression.end, attr.end, ')}');
207+
str.appendLeft(attr.expression.start, '{...__sveltets_empty(');
208+
str.overwrite(
209+
attr.expression.end,
210+
attr.end,
211+
`=__sveltets_instanceOf(${thisType}))}`
212+
);
209213
return;
210214
}
211215
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<><Component type="radio" {...__sveltets_ensureType(Component, element)} value="Plain"/></>
1+
<><Component type="radio" {...__sveltets_empty(element=__sveltets_instanceOf(Component))} value="Plain"/></>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<><sveltebody {...__sveltets_ensureType(HTMLBodyElement, element)} /></>
1+
<><sveltebody {...__sveltets_empty(element=__sveltets_instanceOf(HTMLBodyElement))} /></>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<><sveltecomponent this={A} {...__sveltets_ensureType(__sveltets_componentType(), element)} /></>
1+
<><sveltecomponent this={A} {...__sveltets_empty(element=__sveltets_instanceOf(__sveltets_componentType()))} /></>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
<>{() => {if (false){<>
2-
<svelteself {...__sveltets_ensureType(__sveltets_componentType(), element)} />
2+
<svelteself {...__sveltets_empty(element=__sveltets_instanceOf(__sveltets_componentType()))} />
33
</>}}}</>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<><input type="radio" {...__sveltets_ensureType(HTMLElement, element)} value="Plain"/></>
1+
<><input type="radio" {...__sveltets_empty(element=__sveltets_instanceOf(HTMLElement))} value="Plain"/></>

packages/svelte2tsx/test/sourcemaps/repl.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@
135135
<TableOfContents sections={sections} slug={slug} selected={selected}/>
136136
</div>
137137

138-
<div class="chapter-markup" {...__sveltets_ensureType(HTMLElement, scrollable)}>
138+
<div class="chapter-markup" {...__sveltets_empty(scrollable=__sveltets_instanceOf(HTMLElement))}>
139139
{ chapter.html}
140140

141141
<div class="controls">
@@ -159,7 +159,7 @@
159159

160160
<div class="tutorial-repl">
161161
<Repl
162-
{...__sveltets_ensureType(Repl, repl)}
162+
{...__sveltets_empty(repl=__sveltets_instanceOf(Repl))}
163163
workersUrl="workers"
164164
svelteUrl={svelteUrl}
165165
rollupUrl={rollupUrl}

0 commit comments

Comments
 (0)