-
-
Notifications
You must be signed in to change notification settings - Fork 33
Documentation update & GH templates setup #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for locale-router-static canceled.
|
✅ Deploy Preview for component-scoped-csr canceled.
|
✅ Deploy Preview for locale-router-advanced canceled.
|
✅ Deploy Preview for one-page-example canceled.
|
✅ Deploy Preview for multi-page-example canceled.
|
✅ Deploy Preview for parser-icu canceled.
|
✅ Deploy Preview for parser-default canceled.
|
✅ Deploy Preview for single-load canceled.
|
✅ Deploy Preview for loaders-example canceled.
|
✅ Deploy Preview for locale-param canceled.
|
✅ Deploy Preview for fallback-locale canceled.
|
✅ Deploy Preview for preprocess-example canceled.
|
✅ Deploy Preview for component-scoped-ssr canceled.
|
62788a5 to
eda98d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good updates. Already helpful getting into using the library. Thank you!
For the translation to load, the <key> currently needs to be specified; otherwise, it throws, e.g., No translation nor fallback found for 'greeting'.
ttytm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a minor opinionated change: It might be helpful to split the PR into two - one for the issue template and one for the documentation update. Since each set of changes stands on its own, separating them could help keeping the history clearer.
a89de9d to
80fcd2a
Compare
This PR brings extensive information about
sveltekit-i18necosystem incl. CONTRIBUTION.md and new PR template.