Skip to content

Handle malformed url #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrbean-bremen merged 2 commits into from
Dec 11, 2025
Merged

Handle malformed url #1196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
271d074
Handle malformed url
gaspik Dec 10, 2025
475e5ee
Update release notes
gaspik Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Docs/articles/ReleaseNotes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ The release versions are NuGet releases.

### Changes
* Removed support for unsupported .NET 6 and .NET 7, added support for .NET 9. (see [PR #1192](https://github.com/svg-net/SVG/pull/1192))
* Fixes SVG rendering with invalid syntax, i.e. `fill="url(foo"` where url is not closed properly. (see [PR #1196](https://github.com/svg-net/SVG/pull/1196))

### Enhancements
* Added support for `Switch` element with "systemLanguage" selector attribute (see [#1176](https://github.com/svg-net/SVG/issues/1176)).
Expand Down
7 changes: 6 additions & 1 deletion Source/Painting/SvgPaintServerFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.ComponentModel;
using System.Drawing;
using System.Globalization;
Expand Down Expand Up @@ -32,6 +32,11 @@ public static SvgPaintServer Create(string value, SvgDocument document)
else if (colorValue.StartsWith("url(", StringComparison.OrdinalIgnoreCase))
{
var nextIndex = colorValue.IndexOf(')', 4) + 1;

// Malformed url, missing closing parenthesis
if (nextIndex == 0)
return new SvgDeferredPaintServer(colorValue + ")", null);

var id = colorValue.Substring(0, nextIndex);

colorValue = colorValue.Substring(nextIndex).Trim();
Expand Down
Loading