Skip to content

perf(ls): add cache for getting linting rules #5055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 25, 2025
+12 −4
Merged

perf(ls): add cache for getting linting rules #5055

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e08de8
perf(ls): add cache for linting rules
glowcloud Nov 24, 2025
0bf5261
refactor: use defined const
glowcloud Nov 24, 2025
bf8a976
Merge branch 'main' into perf/ls-validation-performance
glowcloud Nov 24, 2025
588f48a
refactor: set cache after function call
glowcloud Nov 24, 2025
78b9588
Merge branch 'main' into perf/ls-validation-performance
glowcloud Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions packages/apidom-ls/src/services/validation/validation-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ export class DefaultValidationService implements ValidationService {

private quickFixesMap: Record<string, QuickFixData[]> = {};

private lintingRulesSemanticCache: Map<string, LinterMeta[]> = new Map();

public constructor() {
this.validationEnabled = true;
this.commentSeverity = undefined;
Expand Down Expand Up @@ -143,6 +145,12 @@ export class DefaultValidationService implements ValidationService {
}

private getLintingRulesSemantic(doc: Element, symbol: string, docNs: string): LinterMeta[] {
const cacheKey = `${docNs}-${symbol}`;

if (this.lintingRulesSemanticCache.has(cacheKey)) {
return this.lintingRulesSemanticCache.get(cacheKey)!;
}

let meta: LinterMeta[] = [];
const elementMeta = toValue(doc.meta.get('metadataMap')?.get(symbol)?.get('lint'));
if (elementMeta) {
Expand All @@ -151,13 +159,12 @@ export class DefaultValidationService implements ValidationService {
}
// get namespace rules with `given` populated as array
try {
if (!this.settings?.metadata?.rules) {
return meta;
}
const rules = this.settings?.metadata?.rules;
if (!rules[docNs]?.lint) {

if (!rules || !rules[docNs]?.lint) {
return meta;
}

meta = meta.concat(
rules[docNs]!.lint!.filter((r) => {
const matchesArray =
Expand Down Expand Up @@ -682,6 +689,7 @@ export class DefaultValidationService implements ValidationService {
set.forEach((s) => {
// get linter meta from meta
const semanticLintingRules = this.getLintingRulesSemantic(api, s, docNs);
this.lintingRulesSemanticCache.set(`${docNs}-${s}`, semanticLintingRules);
if (semanticLintingRules && semanticLintingRules.length > 0) {
for (const meta of semanticLintingRules) {
this.processRule(
Expand Down