fix: include oauth2-redirect.js in npm package distribution #10585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The oauth2-redirect.js file was missing from the npm package distribution because it wasn't included in the .npmignore whitelist. This file is referenced by oauth2-redirect.html and is required for OAuth2 authentication to work properly. Fixes swagger-api#10574
|
Hi @1234-ad, Thanks for the contribution! The fix looks good, but could you please remove the additional |
|
Hi @glowcloud, Thanks for the feedback! I've removed the The change is ready for review. |
|
🎉 This PR is included in version 5.29.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue #10574: Include oauth2-redirect.js in npm package
Problem
The
oauth2-redirect.jsfile was missing from the npm package distribution, causing OAuth2 authentication to fail when using the npm package. The file exists in the repository and is referenced byoauth2-redirect.html, but wasn't being packaged.Root Cause
The
.npmignorefile uses a whitelist approach (excluding everything with*and then including specific files with!). It included!dist/oauth2-redirect.htmlbut was missing!dist/oauth2-redirect.js.Solution
Added
!dist/oauth2-redirect.jsto the.npmignorefile whitelist.Changes Made
.npmignore: Added!dist/oauth2-redirect.jsto ensure the file is included in npm packagesVerification
After this fix,
npm pack swagger-uiwill include both:dist/oauth2-redirect.html(already included)dist/oauth2-redirect.js(now included)Impact
Testing
The fix can be verified by:
npm pack swagger-uioauth2-redirect.jsis now included in the package contentsThis is a critical fix for OAuth2 functionality that was broken due to missing file packaging.
Fixes #10574