Fix GPG key import #772
Open
Fix GPG key import #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mman
force-pushed
the
fix-gpg-import
branch
from
e1038c1 to
bb9d928
Compare
|
Works like charm! ❤️ |
techouse
approved these changes
Sep 26, 2025
|
It would be great to get this reviewed. It's a real blocker on arrow-swift because PRs just can't get approved because swift-setup is failing randomly. I think only @slashmo can do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To celebrate Server Side Swift Conference 2025 I am proposing a fix to the long-standing issue where import of Swift signing GPG keys fails.
As identified in multiple bug reports, the root cause is that
downloadToolfetching the keys from the swift.org website actually stores gzipped file into a temporary directory, andgpg --importis unable to cope with that.Some people suggested that this may be a problem with the CDN sending
deflateencoding randomly, so I am proposing a robust fix that invokeszcaton the downloaded file and then pipes it intogpg --importviastdin.Tried on couple runs in my private repositories and it seems to work reliably.
Narrator's edit: It did not work reliably. Turns out that sometimes the keys are in plaintext, and sometimes gzipped, we can only speculate why, so I added a more robust logic to handle both cases.
Closes #759, #739, #694, #591, #520, #419.