Remove duplicate module names in diagnostic about missing dependencies #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Clang tracing information currently shows each header file separately, so if there are multiple headers included from the same module, we get duplicates. We are investigating having Clang trace the modules directly and also investigating de-duplicating these diagnostics across targets, but this is easy to fix in the meantime. rdar://156160529
bob-wilson
requested review from
aciidgh,
jakepetroules,
mirza-garibovic,
mhrawdon,
neonichu and
owenv
as code owners
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
neonichu
approved these changes
Jul 22, 2025
|
@swift-ci test |
|
@swift-ci test linux |
jakepetroules
approved these changes
Jul 22, 2025
|
@swift-ci test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Clang tracing information currently shows each header file separately, so if there are multiple headers included from the same module, we get duplicates. We are investigating having Clang trace the modules directly and also investigating de-duplicating these diagnostics across targets, but this is easy to fix in the meantime.
rdar://156160529