Only check isTargetSuitableForPlatformForIndex for workspace description
#671
Conversation
hamishknight
requested review from
aciidgh,
jakepetroules,
mirza-garibovic,
mhrawdon,
neonichu and
owenv
as code owners
hamishknight
force-pushed
the
desc-golf
branch
2 times, most recently
from
3609815 to
c145acc
Compare
|
Linux failure is unrelated, same as e.g https://ci.swift.org/job/pr-swift-build-linux/1074/ |
There was a problem hiding this comment.
Note we don't encounter this issue in the workspace case since there we override the build parameters for host build tools to always build for the host platform.
Just checking I understand this - we override the build parameters for the host tool and then those parameters are passed down to all its dependencies and thus the platform check in isTargetSuitableForPlatformForIndex still passes?
Yes that's correct |
Factor out the creation of the common package dependencies between these two tests.
Use Swift Testing parameterization to test different run destinations.
This better matches what we actually generate for packages. Also set all available platforms as supported.
This exposes the issue where `isTargetSuitableForPlatformForIndex` returns `false` in the target and package build. Also change `testHostToolsAndDependenciesAreBuiltDuringIndexingPreparationForPackage` to use a dependency package and test both the target and package build descriptions.
…ption For the package and target build description we can end up incorrectly dropping build tool dependencies since not all clients pass in the correct dependency information. It's not clear that we actually gain much from doing this check for the target and package build descriptions though, its primary purpose is to avoid configuring unsupported targets in the workspace build description where we try to configure for all available platforms. As such, switch to only checking for the workspace build description. Note we don't encounter this issue in the workspace case since there we override the build parameters for host build tools to always build for the host platform. rdar://152012769
This gets applied pretty inconsistently, only 1 client actually passes the correct dependency information. We ought to be able to rely on the host platform being imposed for the workspace build description, so it shouldn't be necessary.
|
@swift-ci please test |
|
@swift-ci test linux |
|
Ignore Focal CI failures, that was removed in #676. |
For the package and target build description we can end up incorrectly dropping build tool dependencies since not all clients pass in the correct dependency information. It's not clear that we actually gain much from doing this check for the target and package build descriptions though, its primary purpose is to avoid configuring unsupported targets in the workspace build description where we try to configure for all available platforms. As such, switch to only checking for the workspace build description. Note we don't encounter this issue in the workspace case since there we override the build parameters for host build tools to always build for the host platform.
rdar://152012769