[Windows] Improve timer accuracy. #843
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the way timers are implemented so that they will be a lot more accurate on Windows than they were previously. rdar://135413990
This means we no longer need to use `GetProcAddress()` to find the `Query[Unbiased]InterruptTimePrecise()` APIs. rdar://135413990
|
@swift-ci Please test Linux platform |
|
@swift-ci Please test Windows platform |
al45tair
commented
Sep 7, 2024
Tweak the algorithm to avoid spinning in more cases. rdar://135413990
Now that we're directly linking the `Query[Unbiased]InterruptTimePrecise()` function, we don't need this variable or the type declaration next to it. rdar://PR-135413990
|
@swift-ci Please test Linux platform |
|
@swift-ci Please test Windows platform |
|
@swift-ci Please test Linux platform |
|
@swift-ci Please test Windows platform |
|
Windows failure looks like CI has gone wrong trying to check out Swift itself. Will have to get someone to look at that on Monday. |
|
@swift-ci Please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way timers are implemented so that they will be a lot more accurate on Windows than they were previously.
(See also swiftlang/swift#72095)
rdar://135413990