-
Notifications
You must be signed in to change notification settings - Fork 163
resolves mismatched in OpenAPI resource specs for type generation #1239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
Sources/SwiftDocC/SwiftDocC.docc/Resources/LinkableEntities.json
Outdated
Show resolved
Hide resolved
Sources/SwiftDocC/SwiftDocC.docc/Resources/RenderNode.spec.json
Outdated
Show resolved
Hide resolved
Sources/SwiftDocC/SwiftDocC.docc/Resources/RenderNode.spec.json
Outdated
Show resolved
Hide resolved
2316ca5 to
1e93cdc
Compare
|
@swift-ci please test |
|
@franklinsch Updated based on your feedback - tracked down each of the types to verify, and updated the JSON to reflect the corrected types. Please take another look to approve when you've got the time. |
1e93cdc to
498ce90
Compare
|
@swift-ci please test |
franklinsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
@swift-ci please test |
fixes OpenAPI spec mismatches between require properties and available properties
resolves #1222
Summary
Updates the OpenAPI spec files for the outputs used in DocC archive to resolve warnings in mismatches between required fields and available properties defined in those fields
Updates:
Dependencies
none
Testing
Manually verified the output doesn't present warnings when code generation is run with OpenAPI generator:
An example command:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded