Skip to content

Add github workflow to test PR in github actions #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2025
Merged

Add github workflow to test PR in github actions #2006

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f017cfc
Add github workflow to test PR in github actions
cachemeifyoucan Oct 30, 2025
165df4a
Remove the linux_build_command
shahmishal Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
name: Pull request

permissions:
contents: read

on:
pull_request:
types: [opened, reopened, synchronize]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
tests:
name: Test
uses: swiftlang/github-workflows/.github/workflows/swift_package_test.yml@main
with:
linux_os_versions: '["jammy"]'
linux_swift_versions: '["nightly-main", "nightly-6.2"]'
windows_swift_versions: '["nightly-main"]'
windows_build_command: 'Invoke-Program swift test'
enable_linux_static_sdk_build: true
Copy link
Contributor

@jakepetroules jakepetroules Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add:

enable_android_sdk_build: true
enable_ios_checks: true

Copy link
Contributor Author

@cachemeifyoucan cachemeifyoucan Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does that do? We don't have swift driver test case that target those that requires android SDK or iOS sdk. Swift-driver tests are mostly standalone with only execution environment difference.

I did file this: #1828 which might just as well be a separate task in matrix?

Copy link
Member

@compnerd compnerd Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that we should be enabling that - Android is meant to be supported as a host platform not a build platform (i.e. you wouldn't really run the driver on Android, only the generated binaries).

Copy link
Contributor

@jakepetroules jakepetroules Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does that do? We don't have swift driver test case that target those that requires android SDK or iOS sdk. Swift-driver tests are mostly standalone with only execution environment difference.
I did file this: #1828 which might just as well be a separate task in matrix?

Swift Build builds for iOS and Android and depends on Swift driver, I want to avoid regressions getting into the build early.

I'm not sure that we should be enabling that - Android is meant to be supported as a host platform not a build platform (i.e. you wouldn't really run the driver on Android, only the generated binaries).

Some people are using Android as a host.

Copy link
Contributor Author

@cachemeifyoucan cachemeifyoucan Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest have a different set of action to test swift-build. Feel free to add the current list.

Like I said, the build side of the test does not need any SDK. All swift-driver tests need to be standalone without relying on any SDK, and the test case recreates SDK structure if needed.

We never added android Host support for running swift-driver. We need to make sure that works and there is a reason for it to work, before committing resources to it.

linux_static_sdk_build_command: SWIFTBUILD_STATIC_LINK=1 LLBUILD_STATIC_LINK=1 swift build
enable_macos_checks: true
macos_xcode_versions: "[\"26.0\"]"
macos_build_command: swift test

soundness:
name: Soundness
uses: swiftlang/github-workflows/.github/workflows/soundness.yml@main
with:
license_header_check_project_name: "Swift"
api_breakage_check_enabled: false
format_check_enabled: false