Skip to content

Migrate DependencyResolutionTests to Swift Testing #8985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bkhouri
Copy link
Contributor

@bkhouri bkhouri commented Jul 31, 2025

Migrate the Dependency Resolution tests to Swift Testing and augment them to buid against the SwiftBuild build system.

Depends on #8975.
Relates to #8997

@bkhouri bkhouri force-pushed the t/main/migrate_dependency_resolutiontestss_to_st branch from a447a3a to 01d5bd1 Compare August 1, 2025 17:02
@bkhouri
Copy link
Contributor Author

bkhouri commented Aug 5, 2025

@swift-ci test

@bkhouri bkhouri force-pushed the t/main/migrate_dependency_resolutiontestss_to_st branch from 01d5bd1 to 27fa968 Compare August 6, 2025 01:33
@bkhouri
Copy link
Contributor Author

bkhouri commented Aug 6, 2025

@swift-ci test

@bkhouri
Copy link
Contributor Author

bkhouri commented Aug 6, 2025

@swift-ci test windows

@bkhouri bkhouri self-assigned this Aug 6, 2025
@bkhouri bkhouri force-pushed the t/main/migrate_dependency_resolutiontestss_to_st branch from 27fa968 to b300cf0 Compare August 6, 2025 18:01
@bkhouri
Copy link
Contributor Author

bkhouri commented Aug 6, 2025

@swift-ci test

@bkhouri
Copy link
Contributor Author

bkhouri commented Aug 6, 2025

@swift-ci test windows

@bkhouri bkhouri marked this pull request as ready for review August 7, 2025 01:56
@bkhouri bkhouri enabled auto-merge (squash) August 7, 2025 01:56
Copy link
Contributor

@owenv owenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but not sure if others will have opinions on the swift-format config before we merge this, might be worth breaking that out separately

@bkhouri bkhouri force-pushed the t/main/migrate_dependency_resolutiontestss_to_st branch from b300cf0 to 6618e51 Compare August 8, 2025 01:05
@bkhouri
Copy link
Contributor Author

bkhouri commented Aug 8, 2025

@swift-ci test

@bkhouri
Copy link
Contributor Author

bkhouri commented Aug 8, 2025

LGTM but not sure if others will have opinions on the swift-format config before we merge this, might be worth breaking that out separately

makes sense. I removed the .swift-format configuration file from this change and it's being added in #9005

@bkhouri
Copy link
Contributor Author

bkhouri commented Aug 8, 2025

@swift-ci test windows

Migrate the Dependency Resolution tests to Swift Testing and augment
them to buid against the SwiftBuild build system
@bkhouri bkhouri force-pushed the t/main/migrate_dependency_resolutiontestss_to_st branch from 6618e51 to 310638d Compare August 8, 2025 04:26
@bkhouri
Copy link
Contributor Author

bkhouri commented Aug 8, 2025

@swift-ci test

@bkhouri
Copy link
Contributor Author

bkhouri commented Aug 8, 2025

@swift-ci test windows

@bkhouri
Copy link
Contributor Author

bkhouri commented Aug 8, 2025

The windows self-hosted pipeline failed for what appears to be an CI infrastructure issue. I'm retriggering.

00:31:08  jenkins.util.io.CompositeIOException: Unable to delete 'C:\Users\swift-ci\jenkins\workspace\pr-swiftpm-windows-self-hosted'. Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts.

@swift-ci test self hosted windows

@bkhouri bkhouri merged commit 2669cb7 into swiftlang:main Aug 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants