Skip to content

Promote Issue Handling Traits to public API #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2025
Merged

Promote Issue Handling Traits to public API #1198

merged 2 commits into from
Jul 16, 2025

Conversation

stmontgomery
Copy link
Contributor

@stmontgomery stmontgomery commented Jul 2, 2025 •
edited
Loading

This PR promotes issue handling traits (namely, the IssueHandlingTrait type) to non-@_spi public API, now that it has been accepted by the Testing Workgroup.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@stmontgomery stmontgomery added this to the Swift 6.x (main) milestone Jul 2, 2025
@stmontgomery stmontgomery self-assigned this Jul 2, 2025
@stmontgomery stmontgomery added enhancement New feature or request public-api Affects public API issue-handling Related to Issue handling within the testing library traits Issues and PRs related to the trait subsystem or built-in traits documentation 📚 Improvements or additions to documentation labels Jul 2, 2025
@stmontgomery stmontgomery force-pushed the publicize-issue-handling-traits branch from ee3380f to a770f27 Compare July 16, 2025 20:58
@stmontgomery stmontgomery force-pushed the publicize-issue-handling-traits branch from 330d0fb to ea515ef Compare July 16, 2025 21:18
@stmontgomery stmontgomery marked this pull request as ready for review July 16, 2025 21:18
@stmontgomery
Copy link
Contributor Author

@swift-ci please test

@stmontgomery stmontgomery mentioned this pull request Jul 16, 2025
Merged
@stmontgomery stmontgomery merged commit 824f6a4 into swiftlang:main Jul 16, 2025
3 checks passed
@stmontgomery stmontgomery deleted the publicize-issue-handling-traits branch July 16, 2025 23:57
@stmontgomery stmontgomery mentioned this pull request Jul 17, 2025
Merged
@heeb0o-d heeb0o-d mentioned this pull request Aug 22, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briancroom briancroom briancroom approved these changes

@grynspan grynspan Awaiting requested review from grynspan grynspan is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@stmontgomery stmontgomery

Labels
documentation 📚 Improvements or additions to documentation enhancement New feature or request issue-handling Related to Issue handling within the testing library public-api Affects public API traits Issues and PRs related to the trait subsystem or built-in traits
Projects
None yet
Milestone
Swift 6.x (main)
Development

Successfully merging this pull request may close these issues.
2 participants
@stmontgomery @briancroom