[windows] only test the Swift subset of LLDB tests in CI #85075
+13
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test windows |
compnerd
requested changes
Oct 23, 2025
utils/build.ps1
Outdated
| LLVM_UNITTEST_LINK_FLAGS = "$(Get-SwiftSDK -OS Windows -Identifier Windows)\usr\lib\swift\windows\$($Platform.Architecture.LLVMName)\swiftCore.lib"; | ||
| } | ||
|
|
||
| if ($env:ONLY_SWIFT_LLDB_TESTS -eq '1') { |
There was a problem hiding this comment.
I really would rather not introduce this type of behaviour in build.ps1. Can we sink this check into lit itself?
There was a problem hiding this comment.
Would using the check-lldb-swift target be better? https://github.com/swiftlang/llvm-project/blob/b6f1a41420ebffc7f043b16080ef0e8afde4d2cc/lldb/test/CMakeLists.txt#L302-L306
we could have lldb and lldb-swift in the list of tests that build.ps1 supports
|
I opened an alternative PR here: swiftlang/llvm-project#11695 |
charles-zablit
force-pushed
the
charles-zablit/windows/lldb-only-run-swift-test-subset
branch
from
2be681e to
5e5b70e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot break upstream
lldbtests fromswiftlang/swift. This patch adds thecheck-lldb-swifttarget through thelldb-swifttest, which will only check the swift subset of lldb tests.rdar://162128596