[IRGen] Fix call generation to respect C calling conventions. #85081
+124
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On 32-bit Windows, a number of different calling conventions are in use, but Swift ignores them when generating call instructions in IRGen, and generates calls that always use the default calling convention, `cdecl`. This results in stack corruption, because `stdcall` uses the `ret <nn>` instruction, which adds its argument to the stack pointer on return. rdar://163178024
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
We're now passing through the calling convention to LLVM IR (which is correct, but we weren't doing previously). rdar://163178024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 32-bit Windows, a number of different calling conventions are in use, but Swift ignores them when generating call instructions in IRGen, and generates calls that always use the default calling convention,
cdecl. This results in stack corruption, becausestdcalluses theret <nn>instruction, which adds its argument to the stack pointer on return.rdar://163178024