ManualOwnership: provide ability to apply to entire compilation unit #85090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavon
force-pushed
the
manual-ownership/usability-fixes-6
branch
from
393f3f8 to
09abb91
Compare
This includes documentation to explain how to understand these diagnostics.
We can add warnings about dynamic exclusivity checks that may happen on an access, with explainers about why they happen for safety.
kavon
force-pushed
the
manual-ownership/usability-fixes-6
branch
from
09abb91 to
1d6ce7c
Compare
kavon
changed the title
kavon
requested review from
CodaFi,
DougGregor,
bnbarham,
eeckstein,
hamishknight,
hborla,
jckarter,
rintaro,
slavapestov and
xedin
as code owners
|
@swift-ci smoke test |
With this patch, I'm flipping the polarity of things. The flag `-enable-experimental-feature ManualOwnership` now turns on the diagnostics, but they're all silenced by default. So, you need to add -Wwarning or -Werror to your build settings to turn on the specific diagnostics you care about. These are the diagnostic groups relevant to the feature: - SemanticCopies aka "explicit copies mode" - DynamicExclusivity For example, the build setting `-Werror SemanticCopies` now gives you errors about explicit copies, just as before, but now you can make them just warnings with -Wwarning. To opt-out a declaration from everything when using the feature, use @_noManualOwnership. @_manualOwnership is no longer an attribute as a result. resolves rdar://163372569
kavon
force-pushed
the
manual-ownership/usability-fixes-6
branch
from
1d6ce7c to
2d881bd
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm flipping the polarity of things.
The flag
-enable-experimental-feature ManualOwnershipnow turns on the diagnostics,but they're all silenced by default. So, you need to add -Wwarning or -Werror to
your build settings to turn on the specific diagnostics you care about.
These are the diagnostic groups relevant to the feature:
For example, the build setting
-Werror SemanticCopiesnow gives you errors aboutexplicit copies, just as before, but now you can make them just warnings with -Wwarning.
To opt-out a declaration from everything when using the feature, use @_noManualOwnership.
@_manualOwnership is no longer an attribute as a result.
resolves rdar://163372569