[cxx-interop] Check template argument safety in ClangDeclExplicitSafety #85095
+47
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking this upon import was overlooking annotations that explicitly mark a type as safe (or unsafe). Instead, we consolidate this logic in the ClangDeclExplicitSafety request. rdar://163196609
j-hui
requested review from
Xazax-hun,
beccadax,
egorzhdan,
fahadnayyar,
hnrklssn,
ian-twilightcoder,
susmonteiro and
zoecarver
as code owners
|
@swift-ci please test |
Xazax-hun
approved these changes
Oct 23, 2025
hnrklssn
reviewed
Oct 24, 2025
| break; | ||
| case clang::TemplateArgument::Pack: | ||
| for (auto pkArg : arg.getPackAsArray()) { | ||
| if (pkArg.getKind() == clang::TemplateArgument::Type && |
There was a problem hiding this comment.
No, not as far as I'm aware.
|
@swift-ci please test |
|
Note: tests failed because I forgor to account for cycles, e.g., this fun one from libcxx: template <class _Tp>
class allocator : private __non_trivial_if<!is_void<_Tp>::value, allocator<_Tp> > { ... } |
j-hui
force-pushed
the
template-arg-safety-in-req
branch
from
9520c14 to
929d0d8
Compare
|
@swift-ci please test |
|
@swift-ci please test macos platform |
hnrklssn
approved these changes
Oct 24, 2025
|
@swift-ci please test macos platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking this upon import was overlooking annotations that explicitly mark a type as safe (or unsafe). Instead, we consolidate this logic in the ClangDeclExplicitSafety request.
rdar://163196609