Skip to content

[irgen] Convert emitIRGenBuiltin to use a covered switch. #85118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2025
+207 −167
Merged

[irgen] Convert emitIRGenBuiltin to use a covered switch. #85118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e64ea6
[irgen] Refactor llvm intrinsic emission out of emitBuiltinCall.
gottesmm Oct 24, 2025
239807f
[irgen] Convert emitIRGenBuiltin to use a covered switch.
gottesmm Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions include/swift/AST/Builtins.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,10 +209,11 @@ BUILTIN_BINARY_PREDICATE(FCMP_ULE, "fcmp_ule", "n", FloatOrVector)
BUILTIN_BINARY_PREDICATE(FCMP_UNE, "fcmp_une", "n", FloatOrVector)
BUILTIN_BINARY_PREDICATE(FCMP_UNO, "fcmp_uno", "n", FloatOrVector)

// BUILTIN_SIL_OPERATION - Operations that can be lowered to SIL instructions.
// These have various types.
// Since these operations will be lowered to SIL Instructions, we do not
// assign any attributes on them.
// BUILTIN_SIL_OPERATION - Operations that can be lowered to SIL
// instructions. They can never be invoked via a BuiltinInst and are instead
// expected to just be used by SILGen to emit sequences of non-BuiltinInst
// instructions. These have various types. Since these operations will be
// lowered to SIL Instructions, we do not assign any attributes on them.
#ifndef BUILTIN_SIL_OPERATION
#define BUILTIN_SIL_OPERATION(Id, Name, Overload) BUILTIN(Id, Name, "")
#endif
Expand Down Expand Up @@ -558,8 +559,9 @@ BUILTIN_RUNTIME_CALL(ErrorInMain, "errorInMain", "")
/// nominal type is Optional.
BUILTIN_RUNTIME_CALL(IsOptionalType, "isOptional", "")

// BUILTIN_MISC_OPERATION - Miscellaneous operations without a unifying class.
// These have various types.
/// BUILTIN_MISC_OPERATION - Miscellaneous operations without a unifying class.
/// These have various types. They are emitted as BuiltinInst in a standard way
/// by SILGen.
#ifndef BUILTIN_MISC_OPERATION
#define BUILTIN_MISC_OPERATION(Id, Name, Attrs, Overload) \
BUILTIN(Id, Name, Attrs)
Expand Down
Loading