[cmake] fix libswiftCompatibilitySpan for maccatalyst builds #85969
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some build configurations, libswiftCompatibilitySpan was being linked for a newer deployment target than expected.
Contributor
Author
|
@swift-ci please test |
glessard
commented
Dec 11, 2025
| @@ -13,8 +20,6 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Darwin" AND DEFINED SWIFT_STDLIB_LIBRARY_BUILD_TY | |||
|
|
|||
| TARGET_SDKS ${SWIFT_APPLE_PLATFORMS} | |||
|
|
|||
| LINK_FLAGS "${SWIFT_RUNTIME_SWIFT_LINK_FLAGS}" | |||
Contributor
Author
There was a problem hiding this comment.
This is repeated further down – just removing the repetition.
Contributor
Author
|
@swift-ci please test windows platform |
edymtt
reviewed
Dec 11, 2025
Co-authored-by: Eric Miotto <1094986+edymtt@users.noreply.github.com>
Contributor
Author
|
@swift-ci please test |
edymtt
approved these changes
Dec 11, 2025
glessard
changed the title
Contributor
Author
|
@swift-ci please test Windows platform |
Contributor
Author
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some build configurations, libswiftCompatibilitySpan was being linked for a newer deployment target than expected.
Addresses rdar://163874201