SIL: Adjust pack isa after upstream LLVM implementation change
#85971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@swift-ci please smoke test |
See llvm/llvm-project#161403. These `isa` calls with a `CanType` no longer compile with LLVM next because the implementation now unfolds directly to `CastInfo` calls rather than non-variadic `isa` calls that resolve to our partial specializations here: https://github.com/swiftlang/swift/blob/e293876e4f3e376b29cdb225962e1f76cfcfbed7/include/swift/AST/Type.h#L600 We should partially specialize `CastInfo` instead of `isa` et al. For now, just use the non-variadic `isa`.
AnthonyLatsis
force-pushed
the
jepa-main4
branch
from
d6e32df to
9b2a7ef
Compare
Collaborator
Author
|
@swift-ci please smoke test |
Collaborator
Author
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See llvm/llvm-project#161403.
These
isacalls with aCanTypeno longer compile with LLVM next because the implementation now unfolds directly toCastInfocalls rather than non-variadicisacalls that resolve to our partial specializations here:swift/include/swift/AST/Type.h
Line 600 in e293876
We should partially specialize
CastInfoinstead ofisaet al. For now, just use the non-variadicisa.