CAS Support #85978
Draft
CAS Support #85978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a new substitution for use in the CAS tests. The plain variant of the target frontend invokes the tool with the variant target triple and resource dir only. This allows us to properly invoke the frontend for the CAS tests.
Enable the CAS test suite to execute on Windows.
Migrate two more instances of the lit test `RUN` lines to `swift-build-modules` to ensure that all the modules are available for the CAS build.
Adjust the test expectations to account for path separators on Windows.
The plugin server on Windows is an executable and thus has the `.exe` extension that we did not match. Adjust the test for this naming difference.
Ensure that we account for file system arc separators and extensions by using the LLVM functions rather than trying to simply do string matching. This allows us to properly handle the inputs on Windows.
Use `FileCheck` for the test validation instead of `diff`. This allows us to match the different file system arc separator on Windows which is different across the CAS, where everything is normalised, and the uncached path where we get mixed paths.
compnerd
force-pushed
the
cas-support
branch
from
3a46161 to
ab1893e
Compare
Member
Author
|
@swift-ci please smoke test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.