[cxx-interop] Fix crashing on recursive enums #85980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
egorzhdan,
hnrklssn,
j-hui and
susmonteiro
as code owners
egorzhdan
reviewed
Dec 11, 2025
Contributor
egorzhdan
left a comment
egorzhdan
left a comment
There was a problem hiding this comment.
Thanks! Just one comment on the test.
Introduce a cache that helps cutting the recursion when we process a type that we already visited before but did not finish processing yet. Fixes swiftlang#85361 rdar://164153038
Xazax-hun
force-pushed
the
recursive-enums-fix
branch
from
803b537 to
181122e
Compare
Contributor
Author
|
@swift-ci please smoke test |
egorzhdan
approved these changes
Dec 11, 2025
j-hui
approved these changes
Dec 11, 2025
Contributor
Author
|
@swift-ci please smoke test Windows |
susmonteiro
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a cache that helps cutting the recursion when we process a type that we already visited before but did not finish processing yet.
Fixes #85361
rdar://164153038