[build-script] Don't use the just-built dsymutil by default #85985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing so may have made sense back then, but at this point we should default to the one in the toolchain. When building with asserts, the just-built dsymutil will run the DWARF verifier which is slow and not really desirable in this context.
Contributor
Author
|
@swift-ci test |
edymtt
reviewed
Dec 11, 2025
| darwin-deployment-version-xros "1.0" "minimum deployment target version for xrOS" | ||
| darwin-install-extract-symbols "" "whether to extract symbols with dsymutil during installations" | ||
| darwin-install-extract-symbols-use-just-built-dsymutil "1" "whether we should extract symbols using the just built dsymutil" | ||
| darwin-install-extract-symbols-use-just-built-dsymutil "" "whether we should extract symbols using the just built dsymutil" |
Contributor
There was a problem hiding this comment.
This alone will not guarantee that the dsymutil provided by the underlying toolchain/SDK is not built with asserts.
I think a better option is to to add --verify-dwarf none on the invocation on line 3096, and have users override this with --extra-dsymutil-args when needed (assuming dsymutil takes the last option, which I haven't verified)
Contributor
Author
There was a problem hiding this comment.
I can add it, but I still don't think using the just-built dsymutil should be the default.
Contributor
Author
|
@swift-ci test |
edymtt
approved these changes
Dec 11, 2025
Contributor
edymtt
left a comment
edymtt
left a comment
There was a problem hiding this comment.
Please generate the toolchain for macOS (@swift-ci please build toolchain macOS) to be sure we are not regressing the packaging job.
Contributor
Author
|
@swift-ci please build toolchain macOS |
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing so may have made sense back then, but at this point we should default to the one in the toolchain. When building with asserts, the just-built dsymutil will run the DWARF verifier which is slow and not really desirable in this context.