Tolerate undef closure captures in ClosureLifetimeFixup #85987
Merged
+25
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We may see undef closure captures in ClosureLifetimeFixup since it is a mandatory pass that runs on invalid code as well. This could sometimes hang the compiler while running `insertDeallocOfCapturedArguments` in release builds. This change adds a bailout when we see an undef closure capture to avoid running into this issue.
Contributor
Author
|
@swift-ci test |
slavapestov
approved these changes
Dec 11, 2025
Contributor
Author
|
@swift-ci test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may see undef closure captures in ClosureLifetimeFixup since it is a mandatory pass that runs on invalid code as well.
This could sometimes hang the compiler while running
insertDeallocOfCapturedArgumentsin release builds.This change adds a bailout when we see an undef closure capture to avoid running into this issue.