Extract context key management into ContextKeyManager #1992
+917
−394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
0xTim,
adam-fowler and
award999
as code owners
plemarquand
force-pushed
the
context-key-manager-refactor
branch
from
f4b13ce to
3b9ced8
Compare
Attempt to start to reduce the WorkspaceContext's responsibilities by moving context key related logic into a dedicated ContextKeyManager service. Adds many unit tests to support this.
plemarquand
force-pushed
the
context-key-manager-refactor
branch
from
3b9ced8 to
75f8cb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to start to reduce the WorkspaceContext's responsibilities by moving context key related logic into a dedicated ContextKeyManager service.
Adds many unit tests to support this.
Tasks
[ ] Documentation has been updated[ ] Added an entry to CHANGELOG.md if applicable