Added all Switcher Strategies #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the feature request handling system, including support for additional parameter types, improved parameter validation logic, and expanded test coverage to ensure robustness. The changes primarily focus on extending functionality for feature parameters, refining the service logic, and improving test reliability.
Enhancements to feature request handling:
src/dto/feature-request.ts: Added support for new Strategy parameter types (number,date,time,payload,regex,network) in theFeatureRequestDtotype. These parameters are now optional.src/services/feature.ts: RefactoredFeatureServiceto include handlers for validating the new parameter types using theClientlibrary. Validation logic is now dynamically applied based on parameter keys.Improvements to testing:
tests/services/feature.test.ts: Introduced atearDownfunction to ensure proper cleanup after tests by terminating snapshot auto-updates. Added parameterized tests to validate feature enablement for all new parameter types. [1] [2]tests/services/feature.integrated.test.ts: Removed redundant initialization code to streamline the integrated test setup.