Fix _minzoom handling in attribute_function #803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting _minzoom was being overwritten while processing each feature. It needs to be persisted per feature and per layer. This way it's possible to easily add filtering logic based on zoom in the attribute_function.
FirstLastNode() - returns the first and the last node coordinates of a way/relation. WayBearing() - calculates the way's bearing in degrees between the first and the last point of the way/relation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting _minzoom was being overwritten while processing each feature. It needs to be persisted per feature and per layer. This way it's possible to easily add filtering logic based on zoom in the attribute_function.
Fixes #774