Skip to content

feat: nack the messages in case something fails mid processing #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: nack the messages in case something fails mid processing #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion relay/src/task_event_consumer/consumer/rabbitmq/consumer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,17 +217,41 @@ impl TaskEventConsumer for RabbitMQTaskEventConsumer {
Ok(msg) => msg,
Err(e) => {
error!(error = %e, "Error parsing message");

// Nack the message when parsing fails
if let Err(nack_err) = channel
.basic_nack(delivery_tag, lapin::options::BasicNackOptions::default())
.await
{
error!(
error = %nack_err,
delivery_tag = %delivery_tag,
"Failed to nack message after parsing error"
);
}
continue;
}
};

// Handle the event. If it fails, we log it, nack it, and continue.
if let Err(e) = self.handle_events(vec![event]).await {
error!(error = %e, "Error handling events");

// Nack the message when handling fails
if let Err(nack_err) = channel
.basic_nack(delivery_tag, lapin::options::BasicNackOptions::default())
.await
{
error!(
error = %nack_err,
delivery_tag = %delivery_tag,
"Failed to nack message after handling error"
);
}
continue;
}

// Ackowledge the message so we don't re-process it.
// Acknowledge the message when processing is successful
debug!(queue = %QUEUE_NAME, delivery_tag = %delivery_tag, "Acknowledging message");
if let Err(e) = channel
.basic_ack(delivery_tag, BasicAckOptions::default())
Expand Down