Support setting a default letter spacing for a custom font family #19245
+212
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| " | ||
| `) | ||
| }) | ||
|
|
There was a problem hiding this comment.
I kinda feel like this test is redundant (if sans works then mono should work too) — but it matches some of the existing stuff so probably fine.
| test('overriding `fontFamily.sans[1].letterSpacing` sets letter-spacing', async ({ expect }) => { | ||
| let input = css` | ||
| @theme default { | ||
| --default-font-family: var(--font-family-sans); |
There was a problem hiding this comment.
Not for this PR but our default theme uses --theme() instead of var(…). We should probably mirror the actual usage in these tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to set a default letter spacing a given font family, just like how you can set the default
font-feature-settingsandfont-variation-settings.The use case is for things like heading fonts, where maybe you want the letter spacing to always be tighter and you don't want to add
tracking-tightevery time you use it.The letter spacing can still be overridden with explicit tracking utilities.