feat: Universal notification system with retry logic and user preferences

[talkstream]

Summary

This PR contributes a battle-tested notification system from the Kogotochki bot project. The system provides a robust foundation for handling notifications across different messaging platforms.

Key Features

• 🔄 Retry Logic: Automatic retry mechanism with exponential backoff for failed notifications
• 📦 Batch Processing: Efficient batch sending for mass notifications with configurable batch size
• ⚙️ User Preferences: Granular control over notification categories (auction, balance, service, system)
• 🛡️ Error Handling: Graceful handling of blocked users and network errors
• 📊 Monitoring: Built-in Sentry integration for error tracking
• 🌐 Platform Agnostic: Easy to adapt for different messaging platforms (Telegram, Discord, etc.)

Components

NotificationService

• Template-based message generation
• Support for multiple notification types
• Integration with user preferences
• Business logic for different notification scenarios

NotificationConnector

• Low-level message delivery
• Retry mechanism implementation
• Batch processing logic
• Error detection and reporting

Testing

• Comprehensive test suite with 100% coverage
• Tests for all notification types
• Retry logic testing
• Batch processing testing
• Error scenario coverage

Integration

The system includes:

• Example integration code
• Database migration scripts
• UI components for user preferences
• Event system integration examples

Production Usage

This system has been successfully used in production in the Kogotochki bot, handling thousands of notifications daily with excellent reliability.

Related Issues

• Addresses the need for a robust notification system in the wireframe platform
• Provides a foundation for future notification features

Checklist

• Tests pass
• Documentation included
• Example integration provided
• Migration guide included

[talkstream]

📋 Review: Universal Notification System

Thank you for contributing this battle-tested notification system! The implementation looks solid with excellent features like retry logic, batch processing, and user preferences.

⚠️ Issues to Address:

1. Duplicate Files from PR feat: Add D1RunMeta interface for type-safe database operations #16

   • This PR includes D1 type safety files that are already in PR feat: Add D1RunMeta interface for type-safe database operations #16
   • Please rebase on main after PR feat: Add D1RunMeta interface for type-safe database operations #16 is merged to avoid conflicts

2. Domain-Specific Dependencies

   • The notification service depends on Kogotochki-specific types (e.g., AuctionResult from @/domain/models/kogotochki/)
   • For wireframe integration, we need generic interfaces

🔧 Suggested Improvements:

1. Make it truly universal:

   // Instead of specific AuctionResult
   export interface NotificationContext {
     type: string;
     data: Record<string, any>;
   }
   
   // Generic notification method
   sendNotification(userId: number, template: string, context: NotificationContext): Promise<void>;

2. Remove platform-specific imports:

   • Move to src/connectors/notification/ instead of src/contrib/
   • Follow wireframe's connector pattern

3. Add platform adapters:

   • TelegramNotificationAdapter
   • DiscordNotificationAdapter
   • SlackNotificationAdapter

📁 Recommended Structure:

src/connectors/notification/
├── interfaces.ts              # Universal interfaces
├── notification-connector.ts  # Base connector
├── notification-service.ts    # Generic service
├── adapters/
│   ├── telegram.ts
│   └── discord.ts
└── templates/
    └── default.ts

✅ What's Great:

• Excellent retry mechanism implementation
• Well-thought-out batch processing
• Comprehensive test coverage
• Production-proven patterns

📝 Next Steps:

1. Wait for PR feat: Add D1RunMeta interface for type-safe database operations #16 to be merged
2. Rebase and remove duplicate files
3. Refactor to remove domain-specific dependencies
4. Move to proper wireframe structure

This is valuable functionality that would benefit the wireframe community! Let's work together to make it truly platform-agnostic. 🚀

[talkstream]

✅ PR #16 has been merged!

The D1 type safety PR has been successfully merged into main. Please:

1. Rebase your branch on the latest main
2. Remove the duplicate D1 type safety files from this PR
3. Keep only the notification system files

This will clean up the PR and make it ready for merge. Thank you!

[talkstream]

@talkstream The notification system is now ready for review:

• ✅ All TypeScript errors fixed (100% strict mode)
• ✅ Platform-agnostic design - no domain-specific dependencies
• ✅ All tests passing
• ✅ Documentation and examples added
• ✅ Proper import paths without .js extensions

What's included:

Core Components:

• NotificationService - High-level business logic
• NotificationConnector - Delivery with retry logic and batch processing
• NotificationAdapter interface - Platform-specific implementations

Features:

• 🔄 Automatic retry with exponential backoff
• 📦 Batch notifications with configurable delays
• 👤 User preference integration
• 📊 Full event tracking via EventBus
• 🌍 Multi-locale support

Example Implementation:

• Telegram adapter with full TypeScript types
• Complete example in examples/telegram-notifications.ts

I also have an Admin Panel pattern ready to contribute - should I create a separate PR for it?