-
Notifications
You must be signed in to change notification settings - Fork 12
[WIP] Performance improvements #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Conversation
- Used ImageOptim which has default setting of lossless compression
@tallytalwar Can you take a look at the shader errors here, please? Looks like it fails completely in Tangram JS v0.18 while partially fails in v0.16, from
|
@nvkelso Sure, assigned myself to a few things in the description above. |
- ES does not support dash draw rules, until then use special dash styles for dash drawings
- To be uncommented when ES implements dash draw rules
- building-grid - dots - horizontal-bar
- dots-rev was using old define instead of new uniform in color block - horizontal-bars-rev was using incorrect assignment for uniform value
@nvkelso over to you now. |
For the waves shader, I like how the position is constant now, but can we do something similar to the landuse dots in Bubble Wrap dots – where the waves size is more "constant" looking for the 2 major waves, but the new wave that's introduced grows from a pixel to a full line width wave during the zoom?
to
to
|
From @meetar, about the wave pattern: My 2¢: I'd suggest eventually switching to a texture, and crossfading between zooms, as in the current map. I have an example using Tangram here: http://tangrams.github.io/texture-demos/?url=scenes/texture-tiles.yaml |
Cross fade for texture is good, but I think we can have a pure mathematical implementation for desired wave transitions. |
Uh oh!
There was an error while loading. Please reload this page.