Skip to content

etcd: add basic support #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2025
Merged

etcd: add basic support #9

merged 1 commit into from
Nov 20, 2025

Conversation

@bigbes
Copy link
Collaborator

@bigbes bigbes commented Sep 30, 2025 •
edited
Loading

  • implemented etcd driver (backend) for basic storage
  • used etcd testing.LazyCluster for integration testing
  • modified .golangci.yaml to add new library exclusion

Closes TNTP-4189

@bigbes bigbes force-pushed the bigbes/tntp-4189-etcd-driver branch from 1ecc345 to 562c5bc Compare November 5, 2025 23:36
@coveralls
Copy link

coveralls commented Nov 5, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 19530397035

Details

  • 163 of 1192 (13.67%) changed or added relevant lines in 7 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-3.8%) to 20.21%
Changes Missing Coverage Covered Lines Changed/Added Lines %
driver/etcd/operation.go 20 26 76.92%
driver/etcd/predicate.go 37 51 72.55%
driver/etcd/etcd.go 101 120 84.17%
internal/testing/t.go 0 42 0.0%
internal/mocks/etcd_client_mock.go 0 222 0.0%
internal/mocks/etcd_txn_mock.go 0 726 0.0%
Files with Coverage Reduction New Missed Lines %
internal/testing/t.go 2 0.0%
Totals Coverage Status
Change from base Build 19425813532: -3.8%
Covered Lines: 597
Relevant Lines: 2954
💛 - Coveralls

@bigbes bigbes marked this pull request as ready for review November 5, 2025 23:40
@bigbes bigbes force-pushed the bigbes/tntp-4189-etcd-driver branch 2 times, most recently from 61c9309 to 7c76d2e Compare November 6, 2025 14:05
elhimov
elhimov reviewed Nov 14, 2025
View reviewed changes
@oleg-jukovec
Copy link
Collaborator

oleg-jukovec commented Nov 18, 2025

Part of or Closes ?

@oleg-jukovec
Copy link
Collaborator

oleg-jukovec commented Nov 18, 2025 •
edited
Loading

Part of #TNTP-1234 -> Part of TNTP-1234 if so.

oleg-jukovec
oleg-jukovec requested changes Nov 18, 2025
View reviewed changes
@bigbes bigbes force-pushed the bigbes/tntp-4189-etcd-driver branch from 7c76d2e to 07825bf Compare November 19, 2025 21:14
@bigbes bigbes force-pushed the bigbes/tntp-4189-etcd-driver branch 3 times, most recently from 752cf7c to 85640a8 Compare November 20, 2025 07:40
oleg-jukovec
oleg-jukovec requested changes Nov 20, 2025
View reviewed changes
Copy link
Collaborator

@oleg-jukovec oleg-jukovec left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are flaky. Please, fix it.

@bigbes
etcd: add basic support
29406ab 
* implemented etcd driver (backend) for basic storage
* used etcd `testing.LazyCluster` for integration testing
* modified .golangci.yaml to add new library exclusion

Closes TNTP-4189
@bigbes bigbes force-pushed the bigbes/tntp-4189-etcd-driver branch from 85640a8 to 29406ab Compare November 20, 2025 08:26
@bigbes bigbes requested a review from oleg-jukovec November 20, 2025 08:31
@bigbes bigbes merged commit af6baee into master Nov 20, 2025
14 checks passed
@bigbes bigbes deleted the bigbes/tntp-4189-etcd-driver branch November 20, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oleg-jukovec oleg-jukovec oleg-jukovec approved these changes

@elhimov elhimov elhimov approved these changes

@patapenka-alexey patapenka-alexey patapenka-alexey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bigbes @coveralls @oleg-jukovec @elhimov @patapenka-alexey