api: removed Connection deprecated methods #495
+226
−512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
approved these changes
Nov 18, 2025
Collaborator
oleg-jukovec
left a comment
oleg-jukovec
left a comment
There was a problem hiding this comment.
Thank you for the patch!
bigbes
requested changes
Nov 18, 2025
| } | ||
| } | ||
|
|
||
| func TestErrorTypeEval(t *testing.T) { |
Collaborator
There was a problem hiding this comment.
why have you deleted these tests, instead of rewriting it using "NewEvalRequest?"
Collaborator
Author
There was a problem hiding this comment.
My bad, I thought error types of RequestObjects have been tested in other tests, but they haven't. Indeed, I should just rewrite tests, not delete them.
I'll fix this in next commit amendment.
|
|
||
| // ///////////////// | ||
|
|
||
| func TestClient(t *testing.T) { |
Collaborator
There was a problem hiding this comment.
Are you sure all those tests are duplicated?
laines-it
force-pushed
the
laines-it/gh-479-remove-deprecated-connection
branch
from
ba02f67 to
aecaf88
Compare
Removed deprecated `Connection` methods. Related tests are updated (deleted or refactored). Closes #479
laines-it
force-pushed
the
laines-it/gh-479-remove-deprecated-connection
branch
from
aecaf88 to
3bc439e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed deprecated
Connectionmethods.Related tests are updated (deleted or refactored).
I didn't forget about (remove if it is not applicable):
Closes #479