Skip to content

Update Mergeable.php #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Update Mergeable.php #45

wants to merge 2 commits into from
+16 −16

Conversation

@totoprayogo1916
Copy link

MGatner
MGatner approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What advantage does this have over AllowDynamicProperties? Backwards-compatibility?

@jeitnier
Copy link

@MGatner possible to have your suggestion of #[AllowDynamicProperties] implemented? Is this package still maintained? If so I can make a PR for that if needed.

@MGatner
Copy link
Collaborator

MGatner commented Jul 8, 2024

@jeitnier Yes I would rather see the attribute than make this a class extension. If you want open a PR I can work on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatner MGatner MGatner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@totoprayogo1916 @jeitnier @MGatner