fix: don't try to parse inexistent icons #14356
Open
+85
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhyNotHugo
force-pushed
the
explicit-no-icon
branch
from
167d8ca to
37b3de8
Compare
When Tauri is explicitly configured to use no icons via:
"bundle": {
"icon": []
}
It still tries to compile icons in a fallback path of `icons/icon.png`.
This blocks compiling any project unless artwork is in place, even
though this might be entirely beyond scope for a project.
This issue stems from the fact that `Vec<String>` is used to deserialise
icons, so there is no way to distinguish "no explicit value" from
"explicitly instructed to use no value".
Use an `Option<Vec<String>>` to deserialise configured icons, where no
value (None) means "nothing explicitly specified; use the default), and
Some(EmptyVec) means "explicitly requested no icons".
This allows compiling small proof of concept projects without having to
worry about artwork.
Fixes: tauri-apps#14355
WhyNotHugo
force-pushed
the
explicit-no-icon
branch
from
37b3de8 to
1b6b2fd
Compare
|
v2: fixed issue in Building a downstream project with no icons now works fine 👍 |
Package Changes Through 1b6b2fdNo changes. Add a change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Tauri is explicitly configured to use no icons via:
It still tries to compile icons in a fallback path of
icons/icon.png. This blocks compiling any project unless artwork is in place, even though this might be entirely beyond scope for a project.This issue stems from the fact that
Vec<String>is used to deserialise icons, so there is no way to distinguish "no explicit value" from "explicitly instructed to use no value".Use an
Option<Vec<String>>to deserialise configured icons, where no value (None) means "nothing explicitly specified; use the default), and Some(EmptyVec) means "explicitly requested no icons".This allows compiling small proof of concept projects without having to worry about artwork.
Fixes: #14355