[WEBRTC-2963] Flutter SDK - Ice Trickle Support #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add useTrickleIce parameter to Config base class and implementations - Add new socket methods for telnyx_rtc.candidate and telnyx_rtc.endOfCandidates - Create CandidateMessage and EndOfCandidatesMessage classes for JSON-RPC communication - Add getUseTrickleIce() method to TelnyxClient - Update Peer constructor to accept useTrickleIce parameter and implement trickle ICE logic - Modify TelnyxClient newInvite and acceptCall methods to pass useTrickleIce - Implement _sendTrickleCandidate and _sendEndOfCandidates methods in Peer class - Update Profile model to include useTrickleIce field with toJson and copyWith support - Add trickle ICE toggle to demo app overflow menu - Update ProfileProvider with toggleTrickleIce method - Update ConfigHelper to persist useTrickleIce setting in SharedPreferences - Update TelnyxClientViewModel to save/clear useTrickleIce configuration
… config - Remove useTrickleIce from Config classes (base Config, CredentialConfig, TokenConfig) - Remove getUseTrickleIce() method from TelnyxClient - Add useTrickleIce parameter to newInvite() and acceptCall() methods - Update Peer constructor calls to pass useTrickleIce directly - Update demo app to pass useTrickleIce from profile when calling methods - Keep existing socket methods and SDP modifications for trickle ICE support
…se timer for endOfCandidate message incase signalling does not complete
…refix for trickle ice
… move sdp handling methods to SDP Utils class
…tional ice gathering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements Ice Trickle Support for the Flutter SDK as requested in WEBRTC-2963.
Changes Made
Core Configuration
useTrickleIceparameter tonewInviteand 'acceptCall' within TelnyxClientgetUseTrickleIce()method toTelnyxClientfor accessing the configurationSocket Communication
candidateandendOfCandidatestoSocketMethodconstantsCandidateMessageandEndOfCandidatesMessageclasses for JSON-RPC communication with proper message structurePeer Implementation
Peerconstructor to acceptuseTrickleIceparameteronIceCandidatehandler to support both traditional ICE gathering and trickle ICE_sendTrickleCandidatemethod to send individual ICE candidates as they are discovered_sendEndOfCandidatesmethod to signal completion of ICE candidate gatheringTelnyxClient.newInviteandTelnyxClient.acceptCallmethods to passuseTrickleIceparameterDemo App Integration
TelnyxClientViewModelto save and clearuseTrickleIceconfigurationTechnical Details
ICE Candidate Handling
When
useTrickleIceis enabled:telnyx_rtc.candidatemessagestelnyx_rtc.endOfCandidatesmessage is sent when ICE gathering is completeWhen
useTrickleIceis disabled (default):Testing
The implementation maintains backward compatibility with existing functionality while adding the new trickle ICE capability. The default behavior remains unchanged (
useTrickleIce: false).Related