Skip to content

Solve #130 when cookies expiry is 0, unable to successfully adding co… #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qwenode wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solve #130 when cookies expiry is 0, unable to successfully adding co… #264

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
005197b
Solve #130 when cookies expiry is 0, unable to successfully adding co…
qwenode Sep 30, 2021
452e948
go fmt
qwenode Oct 29, 2021
eaaaa05
add document in the AddCookie method in the Selenium interface.
qwenode Oct 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions remote.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"errors"
"fmt"
"io/ioutil"
"math"
"mime"
"net/http"
"net/url"
Expand Down Expand Up @@ -1009,6 +1010,10 @@ func (wd *remoteWD) GetCookies() ([]Cookie, error) {
}

func (wd *remoteWD) AddCookie(cookie *Cookie) error {
//if cookie.Expiry is zero, AddCookie is not effective, @see https://github.com/tebeka/selenium/issues/130
if cookie.Expiry == 0 {
cookie.Expiry = math.MaxUint32
}
return wd.voidCommand("/session/%s/cookie", map[string]*Cookie{
"cookie": cookie,
})
Expand Down