Force port only if not using scheme default #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HttpClient issue the Host header with the port whenever the port is defined. This patch only set the port when not using the default scheme port (80 for http and 443 for https) scheme=http, host=example.com, port=80 => Host: example.com scheme=https, host=example.com, port=443 => Host: example.com scheme=http, host=example.com, port=8080 => Host: example.com:8080 scheme=https, host=example.com, port=8443 => Host: example.com:8443 Change-Id: I19d238c1abd871d2f641a2643770ab8c78594d6f
mildis
force-pushed
the
clean_host_header
branch
from
7adadeb to
8c74b1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpClient issue the Host header with the port whenever the port is defined.
This patch only set the port when not using the default scheme port
(80 for http and 443 for https)
scheme=http, host=example.com, port=80 => Host: example.com
scheme=https, host=example.com, port=443 => Host: example.com
scheme=http, host=example.com, port=8080 => Host: example.com:8080
scheme=https, host=example.com, port=8443 => Host: example.com:8443
Change-Id: I19d238c1abd871d2f641a2643770ab8c78594d6f