🐛 remove TABLE_SCHEMA from SQLite views #112
Conversation
WalkthroughRefactors _mysql_viewdef_to_sqlite from a staticmethod to an instance method, removes schema_name/keep_schema parameters, updates call sites and tests, adds regex fallback stripping on parse failures, and strips database qualifiers from parsed AST nodes before emitting CREATE VIEW SQL. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Caller as _build_create_view_sql
participant T as MySQLtoSQLite._mysql_viewdef_to_sqlite
participant Parser as sqlglot.parse_one
Caller->>T: call(view_select_sql, view_name)
T->>Parser: parse_one(view_select_sql)
alt parse success
Parser-->>T: AST
T->>T: traverse AST\nstrip DB qualifiers from Tables/Columns
T-->>Caller: "CREATE VIEW quoted(view_name) AS <modified SQL>"
else parse failure (ParseError)
Parser-->>T: ParseError
T->>T: regex-strip qualifiers matching self._mysql_database
T-->>Caller: "CREATE VIEW quoted(view_name) AS <stripped SQL>"
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #112 +/- ##
==========================================
+ Coverage 93.44% 93.50% +0.05%
==========================================
Files 8 8
Lines 900 908 +8
==========================================
+ Hits 841 849 +8
Misses 59 59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/mysql_to_sqlite3/transporter.py (1)
912-927: Quote view identifiers via helper to handle embedded quotes safely.Using f'"{view_name}"' can break for names containing double quotes. Reuse _quote_sqlite_identifier for correctness and consistency.
Apply:
- return f'CREATE VIEW IF NOT EXISTS "{view_name}" AS\n{stripped_sql};' + view_ident = self._quote_sqlite_identifier(view_name) + return f"CREATE VIEW IF NOT EXISTS {view_ident} AS\n{stripped_sql};" @@ - sqlite_select = tree.sql(dialect="sqlite") - return f'CREATE VIEW IF NOT EXISTS "{view_name}" AS\n{sqlite_select};' + sqlite_select = tree.sql(dialect="sqlite") + view_ident = self._quote_sqlite_identifier(view_name) + return f"CREATE VIEW IF NOT EXISTS {view_ident} AS\n{sqlite_select};"tests/unit/test_views_sqlglot.py (1)
1-80: Remove duplicated tests and outdated API calls (will fail CI).This file duplicates imports and TestViewsSqlglot; the first block still uses the old signature (schema_name/keep_schema), causing TypeErrors and F811 redefinition errors.
Apply this minimal clean-up: keep the lower, updated block and drop the upper one.
- import re - from unittest.mock import patch - - import pytest - - from mysql_to_sqlite3.transporter import MySQLtoSQLite - - - class TestViewsSqlglot: - def test_mysql_viewdef_to_sqlite_strips_schema_and_transpiles(self) -> None: - mysql_select = "SELECT `u`.`id`, `u`.`name` FROM `db`.`users` AS `u` WHERE `u`.`id` > 1" - # Use an instance to ensure access to _mysql_database for stripping - with patch.object(MySQLtoSQLite, "__init__", return_value=None): - inst = MySQLtoSQLite() # type: ignore[call-arg] - inst._mysql_database = "db" # type: ignore[attr-defined] - sql = inst._mysql_viewdef_to_sqlite( - view_select_sql=mysql_select, - view_name="v_users", - ) - assert sql.startswith('CREATE VIEW IF NOT EXISTS "v_users" AS') - # Ensure schema qualifier was removed - assert '"db".' not in sql - assert "`db`." not in sql - # Ensure it targets sqlite dialect (identifiers quoted with ") - assert 'FROM "users"' in sql - # Ends with single semicolon - assert re.search(r";\s*$", sql) is not None - - def test_mysql_viewdef_to_sqlite_parse_fallback(self, monkeypatch: pytest.MonkeyPatch) -> None: - # Force parse_one to raise so we hit the fallback path - from sqlglot.errors import ParseError - - def boom(*args, **kwargs): - raise ParseError("boom") - - monkeypatch.setattr("mysql_to_sqlite3.transporter.parse_one", boom) - - sql_in = "SELECT 1" - out = MySQLtoSQLite._mysql_viewdef_to_sqlite( - view_select_sql=sql_in, - view_name="v1", - schema_name="db", - ) - assert out.startswith('CREATE VIEW IF NOT EXISTS "v1" AS') - assert "SELECT 1" in out - assert out.strip().endswith(";") - - def test_mysql_viewdef_to_sqlite_parse_fallback_strips_schema(self, monkeypatch: pytest.MonkeyPatch) -> None: - # Force parse_one to raise so we exercise the fallback path with schema qualifiers - from sqlglot.errors import ParseError - - def boom(*args, **kwargs): - raise ParseError("boom") - - monkeypatch.setattr("mysql_to_sqlite3.transporter.parse_one", boom) - - mysql_select = "SELECT `u`.`id` FROM `db`.`users` AS `u` WHERE `u`.`id` > 1" - out = MySQLtoSQLite._mysql_viewdef_to_sqlite( - view_select_sql=mysql_select, - view_name="v_users", - schema_name="db", - ) - # Should not contain schema qualifier anymore - assert "`db`." not in out and '"db".' not in out and " db." not in out - # Should still reference the table name - assert "FROM `users`" in out or 'FROM "users"' in out or "FROM users" in out - assert out.strip().endswith(";") - - def test_mysql_viewdef_to_sqlite_keep_schema_true_preserves_qualifiers(self) -> None: - mysql_select = "SELECT `u`.`id` FROM `db`.`users` AS `u`" - sql = MySQLtoSQLite._mysql_viewdef_to_sqlite( - view_select_sql=mysql_select, - view_name="v_users", - schema_name="db", - keep_schema=True, - ) - # Should not strip the schema when keep_schema=True - assert "`db`." in sql or '"db".' in sql - assert sql.strip().endswith(";") + # (Remove duplicate legacy tests and imports above; keep the updated block below.)Also applies to: 82-90
🧹 Nitpick comments (3)
src/mysql_to_sqlite3/transporter.py (1)
915-924: Make schema-name comparison case-insensitive.MySQL schema casing can vary by platform/settings. Lowercasing avoids missed strips.
Apply:
- if db and db.name.strip('`"') == self._mysql_database: + if db and db.name.strip('`"').lower() == self._mysql_database.lower(): @@ - if db and db.name.strip('`"') == self._mysql_database: + if db and db.name.strip('`"').lower() == self._mysql_database.lower():tests/unit/test_views_sqlglot.py (2)
114-116: Silence “unused arguments” in test monkeypatch helper.Use throwaway names to avoid ARG001 warnings.
Apply:
- def boom(*args, **kwargs): + def boom(*_, **__): raise ParseError("boom")
135-137: Same here: unused arguments in helper.Mirror the change for consistency.
Apply:
- def boom(*args, **kwargs): + def boom(*_, **__): raise ParseError("boom")
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
src/mysql_to_sqlite3/transporter.py(1 hunks)tests/unit/test_views_build_paths_extra.py(1 hunks)tests/unit/test_views_create_view.py(1 hunks)tests/unit/test_views_sqlglot.py(4 hunks)
🧰 Additional context used
📓 Path-based instructions (6)
tests/**
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use pytest; keep tests under tests/ mirroring src/mysql_to_sqlite3/ structure
Files:
tests/unit/test_views_build_paths_extra.pytests/unit/test_views_create_view.pytests/unit/test_views_sqlglot.py
tests/unit/test_*.py
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
tests/unit/test_*.py: Add unit tests in tests/unit/ for isolated helpers; create targeted files named test_.py
Add at least one unit test covering new flag behavior/validation
Add unit tests for new type mappings in _translate_type_from_mysql_to_sqlite
Add unit tests for new default expression translations
Files:
tests/unit/test_views_build_paths_extra.pytests/unit/test_views_create_view.pytests/unit/test_views_sqlglot.py
{src,tests}/**/*.py
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Adhere to lint suite: Black line length 120 and isort profile=black import ordering for all Python files
Files:
tests/unit/test_views_build_paths_extra.pytests/unit/test_views_create_view.pytests/unit/test_views_sqlglot.pysrc/mysql_to_sqlite3/transporter.py
src/mysql_to_sqlite3/transporter.py
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
_
src/mysql_to_sqlite3/transporter.py: Implement and modify core transfer logic (schema introspection, batching, type/default translation, reconnection handling) in transporter.py
Convert AUTO_INCREMENT single primary keys to INTEGER PRIMARY KEY AUTOINCREMENT only when the translated type is integer; log a warning otherwise
Avoid index naming collisions: if an index name equals its table name or --prefix-indices is set, prefix with
Centralize default value translation in _translate_default_from_mysql_to_sqlite; extend this function for new MySQL constructs
Handle JSON columns: if SQLite has JSON1, map MySQL JSON to JSON; otherwise map to TEXT unless --json-as-text is set
Skip foreign key generation when a table subset restriction is applied
Use _setup_logger for logging; do not instantiate new loggers ad hoc
For large tables, prefer chunked transfer using fetchmany(self._chunk_size) and executemany inserts
On CR_SERVER_LOST during schema or data transfer, attempt a single reconnect; preserve this behavior
Disable PRAGMA foreign_keys during bulk load and re-enable in finally; ensure early returns still re-enable
Use INSERT OR IGNORE to handle potential duplicate inserts
Thread new CLI parameters through the MySQLtoSQLite constructor
Raise ValueError in constructor for invalid configuration
When --debug is not set, swallow and log errors; when --debug is set, re-raise for stack inspection
Extend _translate_type_from_mysql_to_sqlite when adding type mappings and add corresponding tests
Extend _translate_default_from_mysql_to_sqlite to support new default expressions and add tests
Centralize progress/UI changes around tqdm and honor the --quiet flagFiles:
src/mysql_to_sqlite3/transporter.pysrc/**/*.py
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Keep mypy passing (Python 3.9 baseline); avoid untyped dynamic attributes in source code
Files:
src/mysql_to_sqlite3/transporter.pysrc/mysql_to_sqlite3/{cli.py,transporter.py}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/mysql_to_sqlite3/{cli.py,transporter.py}: Never log raw passwords
Support --skip-ssl to disable MySQL SSL; default to encrypted where possible and do not silently change defaultsFiles:
src/mysql_to_sqlite3/transporter.py🧠 Learnings (4)
📚 Learning: 2025-10-18T21:08:55.973Z
Learnt from: CR PR: techouse/mysql-to-sqlite3#0 File: .github/copilot-instructions.md:0-0 Timestamp: 2025-10-18T21:08:55.973Z Learning: Applies to tests/unit/test_*.py : Add unit tests for new type mappings in _translate_type_from_mysql_to_sqliteApplied to files:
tests/unit/test_views_sqlglot.py📚 Learning: 2025-10-18T21:08:55.973Z
Learnt from: CR PR: techouse/mysql-to-sqlite3#0 File: .github/copilot-instructions.md:0-0 Timestamp: 2025-10-18T21:08:55.973Z Learning: Applies to src/mysql_to_sqlite3/transporter.py : Extend _translate_type_from_mysql_to_sqlite when adding type mappings and add corresponding testsApplied to files:
tests/unit/test_views_sqlglot.py📚 Learning: 2025-10-18T21:08:55.973Z
Learnt from: CR PR: techouse/mysql-to-sqlite3#0 File: .github/copilot-instructions.md:0-0 Timestamp: 2025-10-18T21:08:55.973Z Learning: Applies to tests/** : Use pytest; keep tests under tests/ mirroring src/mysql_to_sqlite3/ structureApplied to files:
tests/unit/test_views_sqlglot.py📚 Learning: 2025-10-18T21:08:55.973Z
Learnt from: CR PR: techouse/mysql-to-sqlite3#0 File: .github/copilot-instructions.md:0-0 Timestamp: 2025-10-18T21:08:55.973Z Learning: Applies to src/mysql_to_sqlite3/transporter.py : Extend _translate_default_from_mysql_to_sqlite to support new default expressions and add testsApplied to files:
tests/unit/test_views_sqlglot.py🧬 Code graph analysis (1)
tests/unit/test_views_sqlglot.py (1)
src/mysql_to_sqlite3/transporter.py (2)
MySQLtoSQLite(44-1217)_mysql_viewdef_to_sqlite(898-926)🪛 Flake8 (7.3.0)
tests/unit/test_views_sqlglot.py
[error] 82-82: redefinition of unused 're' from line 1
(F811)
[error] 83-83: redefinition of unused 'patch' from line 2
(F811)
[error] 87-87: redefinition of unused 'MySQLtoSQLite' from line 6
(F811)
[error] 90-90: redefinition of unused 'TestViewsSqlglot' from line 9
(F811)
🪛 Ruff (0.14.0)
tests/unit/test_views_sqlglot.py
52-52: Unused function argument:
args(ARG001)
52-52: Unused function argument:
kwargs(ARG001)
82-82: Redefinition of unused
refrom line 1Remove definition:
re(F811)
83-83: Redefinition of unused
patchfrom line 2Remove definition:
patch(F811)
87-87: Redefinition of unused
MySQLtoSQLitefrom line 6Remove definition:
MySQLtoSQLite(F811)
90-90: Redefinition of unused
TestViewsSqlglotfrom line 9(F811)
114-114: Unused function argument:
args(ARG001)
114-114: Unused function argument:
kwargs(ARG001)
135-135: Unused function argument:
args(ARG001)
135-135: Unused function argument:
kwargs(ARG001)
src/mysql_to_sqlite3/transporter.py
905-905: Do not catch blind exception:
Exception(BLE001)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: Test (python3.12, mariadb:10.6, 0, false, 3.12)
- GitHub Check: Test (python3.11, mariadb:10.6, 0, false, 3.11)
- GitHub Check: Test (python3.9, mariadb:10.6, 0, false, 3.9)
- GitHub Check: Test (python3.9, mariadb:10.11, 0, false, 3.9)
- GitHub Check: Test (python3.10, mariadb:10.6, 0, false, 3.10)
- GitHub Check: Test (python3.12, mariadb:10.0, 1, true, 3.12)
- GitHub Check: Test (python3.13, mariadb:10.0, 1, true, 3.13)
- GitHub Check: Test (python3.13, mariadb:10.6, 0, false, 3.13)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (2)
tests/unit/test_views_create_view.py (1)
41-47: LGTM: test double matches the new interface.The fake converter’s signature and staticmethod patch align with the instance method call site; assertions cover the fallback path well.
tests/unit/test_views_build_paths_extra.py (1)
29-35: LGTM: adapter signature updated correctly.The new fake aligns with the simplified method; assertions verify propagation as intended.
…eError and TypeError
… qualifier removal
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/unit/test_views_sqlglot.py (1)
33-36: Silence ARG001 for unused test stub parameters.Rename star-args to underscore variants to satisfy Ruff without changing behaviour.
- def boom(*args, **kwargs): + def boom(*_args, **_kwargs): raise ParseError("boom")Also applies to: 54-57
🧹 Nitpick comments (3)
src/mysql_to_sqlite3/transporter.py (2)
903-914: Make fallback schema stripping case-insensitive.Database names can differ in case; current regexes only match exact case. Use IGNORECASE to robustly strip qualifiers in the fallback path.
- sn = re.escape(self._mysql_database) - for pat in (rf"`{sn}`\.", rf'"{sn}"\.', rf"\b{sn}\."): - stripped_sql = re.sub(pat, "", stripped_sql) + sn = re.escape(self._mysql_database) + for pat in (rf"`{sn}`\.", rf'"{sn}"\.', rf"\b{sn}\."): + stripped_sql = re.sub(pat, "", stripped_sql, flags=re.IGNORECASE)
915-925: Normalise case when removing qualifiers in the AST.Compare schema names case-insensitively to avoid missing matches on platforms where MySQL treats schema names case-insensitively.
- for tbl in tree.find_all(exp.Table): - db = tbl.args.get("db") - if db and db.name.strip('`"') == self._mysql_database: - tbl.set("db", None) + target_db = str(self._mysql_database).lower() + for tbl in tree.find_all(exp.Table): + db = tbl.args.get("db") + if db and getattr(db, "name", None) and db.name.strip('`"').lower() == target_db: + tbl.set("db", None) # Also remove schema qualifiers on fully-qualified columns (db.table.column) - for col in tree.find_all(exp.Column): - db = col.args.get("db") - if db and db.name.strip('`"') == self._mysql_database: - col.set("db", None) + for col in tree.find_all(exp.Column): + db = col.args.get("db") + if db and getattr(db, "name", None) and db.name.strip('`"').lower() == target_db: + col.set("db", None)tests/unit/test_views_sqlglot.py (1)
92-104: Rename test to reflect current behaviour (no keep_schema parameter).The name suggests keep_schema=True, but the body asserts stripping. Rename for clarity.
- def test_mysql_viewdef_to_sqlite_keep_schema_true_preserves_qualifiers(self) -> None: + def test_mysql_viewdef_to_sqlite_strips_matching_schema_qualifiers(self) -> None:
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/mysql_to_sqlite3/transporter.py(1 hunks)tests/unit/test_views_sqlglot.py(3 hunks)
🧰 Additional context used
📓 Path-based instructions (6)
tests/**
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use pytest; keep tests under tests/ mirroring src/mysql_to_sqlite3/ structure
Files:
tests/unit/test_views_sqlglot.py
tests/unit/test_*.py
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
tests/unit/test_*.py: Add unit tests in tests/unit/ for isolated helpers; create targeted files named test_.py
Add at least one unit test covering new flag behavior/validation
Add unit tests for new type mappings in _translate_type_from_mysql_to_sqlite
Add unit tests for new default expression translations
Files:
tests/unit/test_views_sqlglot.py
{src,tests}/**/*.py
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Adhere to lint suite: Black line length 120 and isort profile=black import ordering for all Python files
Files:
tests/unit/test_views_sqlglot.pysrc/mysql_to_sqlite3/transporter.py
src/mysql_to_sqlite3/transporter.py
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
_
src/mysql_to_sqlite3/transporter.py: Implement and modify core transfer logic (schema introspection, batching, type/default translation, reconnection handling) in transporter.py
Convert AUTO_INCREMENT single primary keys to INTEGER PRIMARY KEY AUTOINCREMENT only when the translated type is integer; log a warning otherwise
Avoid index naming collisions: if an index name equals its table name or --prefix-indices is set, prefix with
Centralize default value translation in _translate_default_from_mysql_to_sqlite; extend this function for new MySQL constructs
Handle JSON columns: if SQLite has JSON1, map MySQL JSON to JSON; otherwise map to TEXT unless --json-as-text is set
Skip foreign key generation when a table subset restriction is applied
Use _setup_logger for logging; do not instantiate new loggers ad hoc
For large tables, prefer chunked transfer using fetchmany(self._chunk_size) and executemany inserts
On CR_SERVER_LOST during schema or data transfer, attempt a single reconnect; preserve this behavior
Disable PRAGMA foreign_keys during bulk load and re-enable in finally; ensure early returns still re-enable
Use INSERT OR IGNORE to handle potential duplicate inserts
Thread new CLI parameters through the MySQLtoSQLite constructor
Raise ValueError in constructor for invalid configuration
When --debug is not set, swallow and log errors; when --debug is set, re-raise for stack inspection
Extend _translate_type_from_mysql_to_sqlite when adding type mappings and add corresponding tests
Extend _translate_default_from_mysql_to_sqlite to support new default expressions and add tests
Centralize progress/UI changes around tqdm and honor the --quiet flagFiles:
src/mysql_to_sqlite3/transporter.pysrc/**/*.py
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Keep mypy passing (Python 3.9 baseline); avoid untyped dynamic attributes in source code
Files:
src/mysql_to_sqlite3/transporter.pysrc/mysql_to_sqlite3/{cli.py,transporter.py}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/mysql_to_sqlite3/{cli.py,transporter.py}: Never log raw passwords
Support --skip-ssl to disable MySQL SSL; default to encrypted where possible and do not silently change defaultsFiles:
src/mysql_to_sqlite3/transporter.py🧠 Learnings (3)
📚 Learning: 2025-10-18T21:08:55.973Z
Learnt from: CR PR: techouse/mysql-to-sqlite3#0 File: .github/copilot-instructions.md:0-0 Timestamp: 2025-10-18T21:08:55.973Z Learning: Applies to src/mysql_to_sqlite3/transporter.py : Extend _translate_type_from_mysql_to_sqlite when adding type mappings and add corresponding testsApplied to files:
tests/unit/test_views_sqlglot.py📚 Learning: 2025-10-18T21:08:55.973Z
Learnt from: CR PR: techouse/mysql-to-sqlite3#0 File: .github/copilot-instructions.md:0-0 Timestamp: 2025-10-18T21:08:55.973Z Learning: Applies to src/mysql_to_sqlite3/transporter.py : Extend _translate_default_from_mysql_to_sqlite to support new default expressions and add testsApplied to files:
tests/unit/test_views_sqlglot.py📚 Learning: 2025-10-18T21:08:55.973Z
Learnt from: CR PR: techouse/mysql-to-sqlite3#0 File: .github/copilot-instructions.md:0-0 Timestamp: 2025-10-18T21:08:55.973Z Learning: Applies to tests/unit/test_*.py : Add unit tests for new type mappings in _translate_type_from_mysql_to_sqliteApplied to files:
tests/unit/test_views_sqlglot.py🧬 Code graph analysis (1)
tests/unit/test_views_sqlglot.py (1)
src/mysql_to_sqlite3/transporter.py (2)
MySQLtoSQLite(44-1219)_mysql_viewdef_to_sqlite(898-928)🪛 Ruff (0.14.0)
tests/unit/test_views_sqlglot.py
54-54: Unused function argument:
args(ARG001)
54-54: Unused function argument:
kwargs(ARG001)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: Test (python3.10, mariadb:10.0, 1, true, 3.10)
- GitHub Check: Test (python3.11, mariadb:10.0, 1, true, 3.11)
- GitHub Check: Test (python3.11, mariadb:5.5, 1, true, 3.11)
- GitHub Check: Test (python3.9, mariadb:10.0, 1, true, 3.9)
- GitHub Check: Test (python3.10, mariadb:5.5, 1, true, 3.10)
- GitHub Check: Test (python3.9, mariadb:5.5, 1, true, 3.9)
- GitHub Check: Test (python3.13, mariadb:5.5, 1, true, 3.13)
- GitHub Check: Test (python3.12, mariadb:5.5, 1, true, 3.12)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (2)
src/mysql_to_sqlite3/transporter.py (1)
898-902: LGTM on instance conversion and quoting.Switch to instance method fits the new design, and consistent identifier quoting for the view name looks good.
Also applies to: 927-929
tests/unit/test_views_sqlglot.py (1)
73-91: LGTM: solid coverage for nested qualified columns.Good end-to-end assertion that nested subqueries lose schema qualifiers while preserving table names.
This pull request refactors how MySQL views are converted to SQLite, simplifying the
MySQLtoSQLite._mysql_viewdef_to_sqliteinterface and improving schema qualifier stripping. The method is now an instance method (not static), no longer takesschema_nameorkeep_schemaparameters, and always strips schema qualifiers matching the current database. Tests and code using this method are updated accordingly, and additional test coverage ensures robust handling of schema qualifiers, including in fallback paths and nested queries.Refactoring and simplification:
_mysql_viewdef_to_sqlitefrom a static method to an instance method, removing theschema_nameandkeep_schemaparameters and using the instance's_mysql_databaseattribute to determine which schema qualifiers to strip. The method now always strips schema qualifiers matching the current database from both table and column references, including in fallback scenarios._mysql_viewdef_to_sqlitein the codebase and tests to match the new signature, removingschema_nameandkeep_schemaarguments. [1] [2] [3] [4] [5]Testing improvements:
MySQLtoSQLitewith a configured_mysql_databaseattribute, ensuring correct schema stripping behavior and robust fallback handling when parsing fails. [1] [2]Test maintenance:
patchin test file.