-
-
Notifications
You must be signed in to change notification settings - Fork 65
✨ add Python 3.14 support #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds Python 3.14 across CI, packaging metadata, tox, documentation, and the Docker base image; expands GitHub Actions test matrix to include python3.14 variants for all existing database configurations. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
118-118: Update black's target-version to include Python 3.14.The project now advertises Python 3.14 support (line 38) but Black's target-version (line 118) omits "py314". This inconsistency may result in suboptimal formatting decisions for Python 3.14.
Update the target-version list:
-target-version = ["py39", "py310", "py311", "py312", "py313"] +target-version = ["py39", "py310", "py311", "py312", "py313", "py314"]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.github/workflows/test.yml(11 hunks)CONTRIBUTING.md(1 hunks)Dockerfile(1 hunks)pyproject.toml(1 hunks)tox.ini(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-10-23T18:16:08.709Z
Learnt from: CR
PR: techouse/sqlite3-to-mysql#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-10-23T18:16:08.709Z
Learning: Use tox -e linters before merging (runs black, isort, flake8, pylint, bandit, mypy) and tox -e python3.12 for a test subset
Applied to files:
tox.ini
🔇 Additional comments (5)
Dockerfile (1)
1-1: LGTM – straightforward base image update.The Dockerfile upgrade to python:3.14-alpine aligns correctly with the PR's Python 3.14 support objective. No functional changes beyond the version bump.
CONTRIBUTING.md (1)
16-16: LGTM – documentation updated correctly.The supported Python versions list now accurately reflects Python 3.14 support alongside existing versions. Documentation is clear and consistent with the rest of the PR changes.
pyproject.toml (1)
38-38: LGTM – classifier added correctly.The Python 3.14 classifier is appropriately added to advertise package support.
tox.ini (1)
9-9: LGTM – tox configuration updated correctly.Both envlist (line 9) and gh-actions Python mapping (line 22) correctly add python3.14 support, following the established pattern and ensuring local and CI testing can target the new Python version.
Also applies to: 22-22
.github/workflows/test.yml (1)
77-81: LGTM – CI test matrix comprehensive and consistent.Python 3.14 matrix entries have been added across all 11 database configurations (MariaDB 5.5, 10.0, 10.6, 10.11, 11.4, 11.8 and MySQL 5.5, 5.6, 5.7, 8.0, 8.4) with correct flags preserved for each (experimental, legacy_db). Coverage is complete and follows the established pattern used for Python 3.9–3.13.
Also applies to: 113-117, 149-153, 185-189, 221-225, 257-261, 293-297, 329-333, 365-369, 400-404, 436-440
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #150 +/- ##
=======================================
Coverage 98.32% 98.32%
=======================================
Files 8 8
Lines 1016 1016
=======================================
Hits 999 999
Misses 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This pull request adds support for Python 3.14 throughout the project. The changes ensure that the tool can be built, tested, and run with Python 3.14, updating documentation, configuration files, and CI workflows accordingly.
Python 3.14 support
Dockerfileto usepython:3.14-alpineas the base image, enabling builds and deployments with Python 3.14.envlistandpythonmappings intox.ini, allowing local and CI testing with Python 3.14. [1] [2]classifierssection ofpyproject.tomlto advertise support for Python 3.14 in package metadata.Continuous Integration (CI) updates
.github/workflows/test.yml, both experimental and non-experimental, ensuring full CI coverage for the new Python version. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Documentation
CONTRIBUTING.mdto list Python 3.14 as a supported version, keeping documentation accurate for contributors.