Skip to content

ci(nodejs): add node 24 to test matrix #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 20, 2025
Merged

ci(nodejs): add node 24 to test matrix #1741

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
824801c
ci(nodejs): add node 24 to test matrix
Fdawgs May 8, 2025
3badd52
ci: remove sql server 2017 runs from linux test suite
dhensby May 20, 2025
ca5f194
ci: add node 22.x to linux runs
dhensby May 20, 2025
119a187
ci: bump base runs from ubuntu-22 to ubuntu-24
dhensby May 20, 2025
9ce72a2
ci: msnodesqlv8 tests on node.js >=22
dhensby May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ permissions:
jobs:
commitlint:
name: Lint commits
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
steps:
- name: Checkout code
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand All @@ -34,7 +34,7 @@ jobs:
run: npx commitlint --from ${{ github.event.pull_request.head.sha }}~${{ github.event.pull_request.commits }} --to ${{ github.event.pull_request.head.sha }} --verbose
codelint:
name: Lint code
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
steps:
- name: Checkout code
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand Down Expand Up @@ -67,16 +67,9 @@ jobs:
MSSQL_PASSWORD: 'yourStrong(!)Password'
strategy:
matrix:
os: [ubuntu-20.04, ubuntu-24.04]
node: [18.x, 20.x, 22.x]
sqlserver: [2017, 2019, 2022]
exclude:
- os: ubuntu-24.04
sqlserver: 2017
- os: ubuntu-20.04
sqlserver: 2019
- os: ubuntu-20.04
sqlserver: 2022
os: [ubuntu-24.04]
node: [18.x, 20.x, 22.x, 24.x]
sqlserver: [2019, 2022]
steps:
- name: Checkout code
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Expand Down Expand Up @@ -122,7 +115,7 @@ jobs:
strategy:
matrix:
os: [windows-2019, windows-2022]
node: [18.x, 20.x, 22.x]
node: [18.x, 20.x, 22.x, 24.x]
sqlserver: [2008, 2012, 2014, 2016, 2017, 2019, 2022]
# These sqlserver versions don't work on windows-2022 (at the moment)
exclude:
Expand Down Expand Up @@ -160,16 +153,22 @@ jobs:
- name: Run cli tests
run: npm run test-cli
- name: Install msnodesqlv8
if: ${{ matrix.node != '22.x' }}
if: ${{ matrix.node != '22.x' && matrix.node != '24.x' }}
run: npm install --no-save msnodesqlv8@^2
- name: Run msnodesqlv8 tests
if: ${{ matrix.node != '22.x' }}
if: ${{ matrix.node != '22.x' && matrix.node != '24.x' }}
run: npm run test-msnodesqlv8
- name: Install msnodesqlv8
if: ${{ matrix.node == '22.x' || matrix.node == '24.x' }}
run: npm install --no-save msnodesqlv8@^4
- name: Run msnodesqlv8 tests
if: ${{ matrix.node == '22.x' && matrix.node == '24.x' }}
run: npm run test-msnodesqlv8
release:
name: Release
concurrency: release
if: ${{ github.repository_owner == 'tediousjs' && github.event_name == 'push' && github.actor != 'dependabot[bot]' }}
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
needs:
- commitlint
- codelint
Expand Down