Skip to content

Migrate from sets.{Strings, Byte, Int...} to generic sets.Set #8669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 198 commits into from
Closed

Migrate from sets.{Strings, Byte, Int...} to generic sets.Set #8669

wants to merge 198 commits into from

Conversation

Alhanaqtah
Copy link

@Alhanaqtah Alhanaqtah commented Mar 25, 2025 •
edited
Loading

Changes

The sets library deprecated sets.{String, Byte, Int...} making them obsolete.
Switching to the generic sets.Set ensures compatibility with future versions.

Relate #7374

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

alhanaqtah.usama added 4 commits March 25, 2025 13:27
Migrate from sets.{Strings, Byte, Int...} to generic sets.Set
af15a83
Migrate from sets.{Strings, Byte, Int...} to generic sets.Set
cb1d760 
The sets library deprecated sets.String, Byte, and Int... making them obsolete.
Switching to the generic sets.Set ensures compatibility with future versions.
Merge branch 'use-generic-sets' of https://github.com/Alhanaqtah/pipe…
1eb2cea 
…line into use-generic-sets
go version fix
1185f94
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Mar 25, 2025
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Mar 25, 2025 •
edited
Loading

CLA Missing ID CLA Not Signed

@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 25, 2025
@Alhanaqtah
Copy link
Author

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Mar 25, 2025
@Alhanaqtah Alhanaqtah changed the title Use generic sets Migrate from sets.{Strings, Byte, Int...} to generic sets.Set Mar 25, 2025
@Alhanaqtah
cosmetic fix
0374775 
Migrate from sets.{Strings, Byte, Int...} to generic sets.Set
@Alhanaqtah
Copy link
Author

/assign @vdemeester

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from vdemeester after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Alhanaqtah Alhanaqtah closed this Mar 30, 2025
@Alhanaqtah Alhanaqtah reopened this Mar 30, 2025
@github-project-automation github-project-automation bot moved this from Done to In Progress in Tekton Community Roadmap Mar 30, 2025
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2025
@tekton-robot
Copy link
Collaborator

@Alhanaqtah: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dependabot bot and others added 25 commits July 29, 2025 21:11
@dependabot
build(deps): bump github.com/spiffe/spire-api-sdk from 1.12.0 to 1.12.4
31a26e0 
Bumps [github.com/spiffe/spire-api-sdk](https://github.com/spiffe/spire-api-sdk) from 1.12.0 to 1.12.4.
- [Commits](spiffe/spire-api-sdk@v1.12.0...v1.12.4)

---
updated-dependencies:
- dependency-name: github.com/spiffe/spire-api-sdk
  dependency-version: 1.12.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@afrittoli
Add a tool to generate the release name
c9b204e 
Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
@vdemeester
Remove linux/arm from platform we publish
910f651 
There is likely *no* kubernetes cluster running linux/arm (v5, v6 or
v7), so removing it to reduce build and release time.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@khrm
Re-register metrics only during real updation
f3eabd4 
Before this, metrics were beign registered and unregisterd even
when anything in configMap used to change including revision, etc.
This causes gap in the metrics and gives us incorrect data over a
long time if configmap revision changes.

Assisted-by: Gemini for unit testing
@dependabot
build(deps): bump github.com/jenkins-x/go-scm from 1.14.58 to 1.14.59
4e0bcae 
Bumps [github.com/jenkins-x/go-scm](https://github.com/jenkins-x/go-scm) from 1.14.58 to 1.14.59.
- [Release notes](https://github.com/jenkins-x/go-scm/releases)
- [Changelog](https://github.com/jenkins-x/go-scm/blob/main/CHANGELOG.md)
- [Commits](jenkins-x/go-scm@v1.14.58...v1.14.59)

---
updated-dependencies:
- dependency-name: github.com/jenkins-x/go-scm
  dependency-version: 1.14.59
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
build(deps): bump the all group in /tekton with 4 updates
f26517c 
Bumps the all group in /tekton with 4 updates: [chainguard/crane](https://github.com/chainguard-images/images), [chainguard/go](https://github.com/chainguard-images/images), tektoncd/plumbing/ko and tektoncd/plumbing/koparse.


Updates `chainguard/crane` from `3481a43` to `6b052a3`
- [Commits](https://github.com/chainguard-images/images/commits)

Updates `chainguard/go` from `65c0048` to `3d0406e`
- [Commits](https://github.com/chainguard-images/images/commits)

Updates `tektoncd/plumbing/ko` from `ec0db95` to `67e0094`

Updates `tektoncd/plumbing/koparse` from `a760454` to `bc4641d`

---
updated-dependencies:
- dependency-name: chainguard/crane
  dependency-version: latest-dev
  dependency-type: direct:production
  dependency-group: all
- dependency-name: chainguard/go
  dependency-version: latest-dev
  dependency-type: direct:production
  dependency-group: all
- dependency-name: tektoncd/plumbing/ko
  dependency-version: 67e0094e43a41be52c0e8c25917c7abb0470686ee3f66c042b62928c96d55cb1
  dependency-type: direct:production
  dependency-group: all
- dependency-name: tektoncd/plumbing/koparse
  dependency-version: bc4641d082e52ea4567528578d49fee624c691c8253ab0c682820858379334dc
  dependency-type: direct:production
  dependency-group: all
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
build(deps): bump tj-actions/changed-files
2298032 
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from e8772ff27de71367c2771ef3e8b5b2075b3f8282 to cf79a64fed8a943fb1073260883d08fe0dfb4e56.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@e8772ff...cf79a64)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-version: cf79a64fed8a943fb1073260883d08fe0dfb4e56
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@vdemeester
Remove all reference to gcr.io tekton projects
cc7e965 
There was still a few references that makes the CI fail. This should
fix it.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@dependabot
build(deps): bump golang.org/x/sync from 0.15.0 to 0.16.0
cbe9329 
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.15.0 to 0.16.0.
- [Commits](golang/sync@v0.15.0...v0.16.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sync
  dependency-version: 0.16.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
build(deps): bump the all group in /tekton with 4 updates
55a9389 
Bumps the all group in /tekton with 4 updates: [chainguard/crane](https://github.com/chainguard-images/images), [chainguard/go](https://github.com/chainguard-images/images), tektoncd/plumbing/ko and tektoncd/plumbing/koparse.


Updates `chainguard/crane` from `6b052a3` to `d7c724c`
- [Commits](https://github.com/chainguard-images/images/commits)

Updates `chainguard/go` from `3d0406e` to `dae27fe`
- [Commits](https://github.com/chainguard-images/images/commits)

Updates `tektoncd/plumbing/ko` from `67e0094` to `29ddcb6`

Updates `tektoncd/plumbing/koparse` from `bc4641d` to `1898ef5`

---
updated-dependencies:
- dependency-name: chainguard/crane
  dependency-version: latest-dev
  dependency-type: direct:production
  dependency-group: all
- dependency-name: chainguard/go
  dependency-version: latest-dev
  dependency-type: direct:production
  dependency-group: all
- dependency-name: tektoncd/plumbing/ko
  dependency-version: 29ddcb636e24c91210b2137ab3816aa7c8e4dcc46afe1c1beba5c60bec155b42
  dependency-type: direct:production
  dependency-group: all
- dependency-name: tektoncd/plumbing/koparse
  dependency-version: 1898ef549aaff602d06c049136aaf1c1eacc573846c42bbf42d8dc9258235204
  dependency-type: direct:production
  dependency-group: all
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
build(deps): bump tj-actions/changed-files
2e49078 
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from cf79a64fed8a943fb1073260883d08fe0dfb4e56 to 055970845dd036d7345da7399b7e89f2e10f2b04.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@cf79a64...0559708)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-version: '055970845dd036d7345da7399b7e89f2e10f2b04'
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
build(deps): bump github.com/jenkins-x/go-scm from 1.14.59 to 1.15.1
aee09cb 
Bumps [github.com/jenkins-x/go-scm](https://github.com/jenkins-x/go-scm) from 1.14.59 to 1.15.1.
- [Release notes](https://github.com/jenkins-x/go-scm/releases)
- [Changelog](https://github.com/jenkins-x/go-scm/blob/main/CHANGELOG.md)
- [Commits](jenkins-x/go-scm@v1.14.59...v1.15.1)

---
updated-dependencies:
- dependency-name: github.com/jenkins-x/go-scm
  dependency-version: 1.15.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
build(deps): bump k8s.io/api from 0.32.6 to 0.32.7
528ba49 
Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.32.6 to 0.32.7.
- [Commits](kubernetes/api@v0.32.6...v0.32.7)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-version: 0.32.7
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@khrm
Stop emitting deprecated metrics
d3b695e 
This commit removes the following deprecated metrics that have been
replaced with corresponding metrics.
We have given sufficient time to user to migrate to newer metrics.
@dependabot
build(deps): bump github.com/google/cel-go from 0.25.0 to 0.26.0
c76dc6f 
Bumps [github.com/google/cel-go](https://github.com/google/cel-go) from 0.25.0 to 0.26.0.
- [Release notes](https://github.com/google/cel-go/releases)
- [Commits](google/cel-go@v0.25.0...v0.26.0)

---
updated-dependencies:
- dependency-name: github.com/google/cel-go
  dependency-version: 0.26.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
build(deps): bump k8s.io/code-generator from 0.32.6 to 0.32.7
1a5ed20 
Bumps [k8s.io/code-generator](https://github.com/kubernetes/code-generator) from 0.32.6 to 0.32.7.
- [Commits](kubernetes/code-generator@v0.32.6...v0.32.7)

---
updated-dependencies:
- dependency-name: k8s.io/code-generator
  dependency-version: 0.32.7
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@vdemeester
Update kubernetes version of the CI
7484ed5 
We are lagging a bit behind in terms of kubernetes version we test
against. This updates to run on more "recent" versions of Kubernetes.

This also removes some old, unsupported version of Kubernetes from
`setup-kind.sh`.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@dependabot
build(deps): bump k8s.io/client-go from 0.32.6 to 0.32.7
9976281 
---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-version: 0.32.7
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
build(deps): bump the all group in /tekton with 3 updates
e4a1961 
---
updated-dependencies:
- dependency-name: chainguard/crane
  dependency-version: latest-dev
  dependency-type: direct:production
  dependency-group: all
- dependency-name: chainguard/go
  dependency-version: latest-dev
  dependency-type: direct:production
  dependency-group: all
- dependency-name: tektoncd/plumbing/ko
  dependency-version: d21b05e426096c01ea026678a94d019f860e5ba04929b5fd2dd8bb0aaccf31d2
  dependency-type: direct:production
  dependency-group: all
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
build(deps): bump step-security/harden-runner from 2.12.2 to 2.13.0
e5b294d 
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.12.2 to 2.13.0.
- [Release notes](https://github.com/step-security/harden-runner/releases)
- [Commits](step-security/harden-runner@6c439dc...ec9f2d5)

---
updated-dependencies:
- dependency-name: step-security/harden-runner
  dependency-version: 2.13.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@vdemeester
Resolvers: remove default TEKTON_HUB_API URI
52836f8 
With the hub deprecation and up-coming shutdown of the hub.tekton.dev
instance, we should stop having a default value for the TEKTON_HUB_API
uri.

This doesn't stop users to use their own instance of the tektoncd/hub
with the resolver.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@vdemeester
Make sure we do not validate ResolutionRequest on DELETE
0096b2b 
This is mainly to keep it consistent with the rest of the object that
are not getting validated on deletion.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@twoGiants
docs: add debugging controllers documentation
b25e5ba 
Issue tektoncd#8876.

Signed-off-by: Stanislav Jakuschevskij <stas@two-giants.com>
@dependabot
build(deps): bump github/codeql-action from 3.29.2 to 3.29.3
ed5e8e4 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.29.2 to 3.29.3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@181d5ee...d6bbdef)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.29.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Migrate from sets.{Strings, Byte, Int...} to generic sets.Set
288eef8 
The sets library deprecated sets.String, Byte, and Int... making them obsolete.
Switching to the generic sets.Set ensures compatibility with future versions.
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 4, 2025
@tekton-robot
Copy link
Collaborator

The following Tekton test failed:

Test name Commit Details Required Rerun command
pull-tekton-pipeline-go-coverage-df 288eef8 link true /test pull-tekton-pipeline-go-coverage-df

@Alhanaqtah Alhanaqtah closed this Aug 4, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Tekton Community Roadmap Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli Awaiting requested review from afrittoli

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@vdemeester vdemeester

Labels
kind/misc Categorizes issue or PR as a miscellaneuous one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Tekton Community Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.