V2 refactor #36
Merged
V2 refactor #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request #30 from telexintegrations/main
This commit establishes the v1-legacy branch to maintain the customizable version of Commit Quality Monitor. This version includes: - Configurable commit types, examples, and training data - Dynamic analyzer settings through Telex This branch serves as a stable reference for teams requiring customization capabilities while we move forward with v2's simplified architecture in main. The main branch README will document both versions and their distinct features.
BREAKING CHANGE: Remove runtime customization of commit rules - Remove custom commit types, examples, and training data configuration - Simplify webhook flow to direct Github -> Analysis -> Telex (-> Slack) - Update integration config for pre-configured settings This change maintains core analysis capabilities without runtime configuration. Users requiring customization can still use v1 branch.
- remove `.lower()` method on `is_test` parameter This fixes the attribute error when the query parameter is not given or None
- dedent and serialize payload to a format acceptable by slack webhook This fixes the 'expected str, bytes or os.PathLike object, not NoneType' when sending to slack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.