Add temporal relevant attributes to spans #1911
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `workflowType`, `activityType`, `namespace`, `taskQueue` attributes to `ExecuteActivity` and `ExecuteWorkflow` spans
|
|
|
I am not sure we want to add this information for every user of tracing of the Go SDK. Commercial telemetry providers may charge per attribute on a span, so to sometimes more than double attribute counts on users just because they upgrade SDK versions is a bit rough. We may be able to discuss options on how you can customize the attributes at span creation time. See #1330 where there has been some discussion here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added
workflowType,activityType,namespace,taskQueueattributes toExecuteActivityandExecuteWorkflowspansWhy?
Important attributes relevant to temporal were missing from the tracing data for better analysis
Checklist
How was this tested:
Tested locally by enabling trace intercept and sending data to SigNoz
Any docs updates needed?
None