Add cause to RespondQueryTaskCompletedRequest #1982
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1822,9 +1822,11 @@ func (wth *workflowTaskHandlerImpl) completeWorkflow( | |||
| ) interface{} { | |||
| // for query task | |||
| if task.Query != nil { | |||
| cause := errToWorkflowTaskFailedCause(workflowContext.err) | |||
There was a problem hiding this comment.
Nit: To test you might want to use a gRPC interceptor to verify the cause is sent since it won't be written to history
|
Marking as draft, this code path is currently impossible to exercise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Support adding
Causeto RespondQueryTaskCompletedRequestNeed to wait for next
api-gorelease before mergingWhy?
API change
Checklist
Closes [go] Add
WorkflowTaskFailedCausetoRespondQueryTaskCompletedRequest#1971How was this tested: