CHASM: SQL separate ID spaces #8915
Open
+835
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prathyushpv
reviewed
Jan 7, 2026
| ctx context.Context, | ||
| row *sqlplugin.CurrentExecutionsRow, | ||
| ) (sql.Result, error) { | ||
| if row.ArchetypeID == chasm.WorkflowArchetypeID { |
Contributor
There was a problem hiding this comment.
Don't we also need to check for 0 here for backward compatibility?
like archetypeID == chasm.WorkflowArchetypeID || archetypeID == chasm.UnspecifiedArchetypeID
Member
Author
There was a problem hiding this comment.
no, not really. Even for existing executions, application layer will pass down chasm.WorkflowArchetypeID.
There's also a check in execution manager to guarantee that 0 is never used: https://github.com/temporalio/temporal/blob/main/common/persistence/execution_manager.go#L1186
prathyushpv
reviewed
Jan 8, 2026
|
|
||
| func (s *ExecutionMutableStateSuite) TestArchetypeSeparateIDSpace() { | ||
| if strings.HasPrefix(s.T().Name(), "TestCassandra") { | ||
| s.T().Skip("Separate ID space is only implemented by sql persistence") |
Contributor
There was a problem hiding this comment.
Please remember to remove this after merging Cassandra changes.
prathyushpv
reviewed
Jan 8, 2026
| SetupPostgreSQLSchema(p.T(), cfg) | ||
| store, err := sql.NewSQLDB(sqlplugin.DbKindMain, cfg, resolver.NewNoopResolver(), log.NewTestLogger(), metrics.NoopMetricsHandler) | ||
| if err != nil { | ||
| p.T().Fatalf("unable to create MySQL DB: %v", err) |
Contributor
There was a problem hiding this comment.
Suggested change
| p.T().Fatalf("unable to create MySQL DB: %v", err) | |
| p.T().Fatalf("unable to create PostgreSQL DB: %v", err) |
prathyushpv
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?