fix(frontend): return error when creating duplicate search attributes #8934
+13
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's being changed:
This PR changes the behavior of
AddSearchAttributesto return a clear error when trying to add a search attribute that already exists (Fixes #8631).The Issue:
In the past, the server would log a warning and return
nil(success) when a duplicate was found. This led clients, such as the CLI, to report "Search attributes have been added" even though no changes were made.The Fix:
I updated
addSearchAttributesElasticsearchandaddSearchAttributesSQLto returnserviceerror.NewAlreadyExistsright away when a duplicate alias or field is detected.Test Coverage:
I modified
Test_AddSearchAttributesElasticsearchandTest_AddSearchAttributesSQLinoperator_handler_test.goto expect this new error instead of the earlier success-with-warning behavior.Review checklist